From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 650BC3858D1E for ; Sat, 11 Mar 2023 15:10:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 650BC3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id AB9EE1004A40E for ; Sat, 11 Mar 2023 15:10:03 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id b0rDpEwhCoCvYb0rDpeA66; Sat, 11 Mar 2023 15:10:03 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Q9cXX66a c=1 sm=1 tr=0 ts=640c99cb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=dzWzf_mpAAAA:8 a=rjei8GaKwoBxy79Ra-oA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uaMaIeSKXwqDRl7XEc/lrafIkzbd6wFTE2zG1B609FE=; b=cgmgcLGa2wiNEVRlCZw/CvOUuL QxOFkMYascQ3Y5L79AsY45zZOs/DxmKs7febDxKaunTNjGzW48E5DBua6Rnlwbv7lPLM/zDyVQqjN ZIG/RvEVsEK+i/0J+RpuUnDBx; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:54320 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pb0rD-001S8T-EC; Sat, 11 Mar 2023 08:10:03 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix htab_t pretty-printer for NULL values References: <20230308205628.4021427-1-tom@tromey.com> <41ac36c3-2c31-c78b-9d48-57be9402bf14@simark.ca> X-Attribution: Tom Date: Sat, 11 Mar 2023 08:09:59 -0700 In-Reply-To: <41ac36c3-2c31-c78b-9d48-57be9402bf14@simark.ca> (Simon Marchi's message of "Fri, 10 Mar 2023 22:15:50 -0500") Message-ID: <87o7oze33s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1pb0rD-001S8T-EC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (prentzel) [71.211.185.113]:54320 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: >> + gdb_test -prompt $outer_prompt_re "print (htab_t) 0x0" \ >> + [string_to_regexp " = (null)"] Simon> Instead of hardcoding (null), what about not selecting the pretty Simon> printer when the value is nullptr? Like this: That seems fine, how about we go with your patch? Simon> Can the value's value change after a pretty printer was selected for it? Nope. Tom