From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id DB33F3858C53 for ; Tue, 7 Mar 2023 21:32:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB33F3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 4D1A81003BDE9 for ; Tue, 7 Mar 2023 21:32:42 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ZevKpgt1ZBwvKZevKpmfwu; Tue, 07 Mar 2023 21:32:42 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Jqk0EO0C c=1 sm=1 tr=0 ts=6407ad7a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=C8zQyGpitMzQufIWG7UA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3BfbCV/J1e8IuXJ5i/9RQIo/gTKZIV3PdjX1RDGXogM=; b=AaJkSLbMC6W7AxvCHG9kIRg4NK boS+h4ZG/g24u5H1zRex9GQXLm7PleZGPbLaNgqBjJ22RG8xdmIgvt/hV0FlOYmra4T2X+MTj3QUa Mez0drYqBAVsR7QDW1xbPB59a; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:33186 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pZevK-002gBr-4N; Tue, 07 Mar 2023 14:32:42 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Clean up attribute reprocessing References: <20230212231239.535298-1-tom@tromey.com> X-Attribution: Tom Date: Tue, 07 Mar 2023 14:32:40 -0700 In-Reply-To: <20230212231239.535298-1-tom@tromey.com> (Tom Tromey's message of "Sun, 12 Feb 2023 16:12:39 -0700") Message-ID: <87o7p4p7rb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pZevK-002gBr-4N X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:33186 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> I ran across the attribute reprocessing code recently and noticed that Tom> it unconditionally sets members of the CU when reading a DIE. Also, Tom> each spot reading attributes needs to be careful to "reprocess" them Tom> as a separate step. Tom> This seemed excessive to me, because while reprocessing applies to any Tom> DIE, setting the CU members is only necessary for the toplevel DIE in Tom> any given CU. Tom> This patch introduces a new read_toplevel_die function and changes a Tom> few spots to call it. This is easily done because reading the Tom> toplevel DIE is already special. I'm going to check this in now. Tom