From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 36D243858C20 for ; Tue, 7 Mar 2023 15:17:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36D243858C20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 022781003FCCF for ; Tue, 7 Mar 2023 15:17:16 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ZZ3zpjj4FbQKPZZ3zpeKU7; Tue, 07 Mar 2023 15:17:15 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Jd15EWGV c=1 sm=1 tr=0 ts=6407557b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=7T9NDxh3fNjHWxFa_h4A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=D2XQaWNFkeOS/zga6Ro56DtoT0QwPGZGYEOGvf6Rq50=; b=nC5niquFXnFU7L7ObkNT4MW8zk jQsdxKH4Kzzw3zoAY7bB1vak90b6F9dV626SFZRLXeVEXQp0nX+uegMkouwJAXFKYSagdZPXUY32Z 9mzXiGPv6TCmho7P29UlUc/rV; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:50642 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pZZ3z-001PqY-JX; Tue, 07 Mar 2023 08:17:15 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCHv2 4/5] gdb/gdbarch: remove the 'invalid=None' state from gdbarch_components.py References: <7452e65c89feea14efa71eb0272e00c2e68f6afd.1678116328.git.aburgess@redhat.com> X-Attribution: Tom Date: Tue, 07 Mar 2023 08:17:10 -0700 In-Reply-To: <7452e65c89feea14efa71eb0272e00c2e68f6afd.1678116328.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Mon, 6 Mar 2023 15:31:56 +0000") Message-ID: <87o7p4sia1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pZZ3z-001PqY-JX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:50642 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> --- a/gdb/gdbarch_components.py Andrew> +++ b/gdb/gdbarch_components.py Andrew> @@ -1675,6 +1675,7 @@ BFD target to use when generating a core file. Andrew> predicate=True, Andrew> predefault="0", Andrew> printer="pstring (gdbarch->gcore_bfd_target)", Andrew> + invalid=True Super nit, but it's better to have a trailing comma here, because it means that future additions can be done without touching this line. Tom