From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 9CE443858D33 for ; Thu, 2 Mar 2023 02:15:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CE443858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id D57EB100417DD for ; Thu, 2 Mar 2023 02:15:46 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id XYTypwJEXuVTuXYTypzhTl; Thu, 02 Mar 2023 02:15:46 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=UcqU9IeN c=1 sm=1 tr=0 ts=640006d2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=gVqZH7sZ9ztccShDXLQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j7oXEZ97IY81I7JFlhX04LL/qKPJlv4S08MkjBGvKVY=; b=UtnEG/mn5R/KJpJOlHfCCGiZhy bdPiMWENplZaEPBVTaJWPLy9/LBxOugkm53VtvYsibsq+qljkrxNPgEVRVPhjkEWTElVJJ7Jp+o0o BVd8GYuThnN1sw+zSCVsMViLU; Received: from [161.98.8.3] (port=59968 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pXYTy-00184w-GU; Wed, 01 Mar 2023 19:15:46 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Clean up attribute reprocessing References: <20230212231239.535298-1-tom@tromey.com> X-Attribution: Tom Date: Wed, 01 Mar 2023 19:15:42 -0700 In-Reply-To: <20230212231239.535298-1-tom@tromey.com> (Tom Tromey's message of "Sun, 12 Feb 2023 16:12:39 -0700") Message-ID: <87o7pblwz5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.3 X-Source-L: No X-Exim-ID: 1pXYTy-00184w-GU X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel) [161.98.8.3]:59968 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> This patch introduces a new read_toplevel_die function and changes a Tom> few spots to call it. This is easily done because reading the Tom> toplevel DIE is already special. Tom> I left the reprocessing flag and associated checks in attribute. It Tom> could be stripped out, but I am not sure it would provide much value Tom> (maybe some iota of performance). I found one small bug in this patch: Tom> + /* Push an element into ATTRIBUTES. */ Tom> + auto push_back = [&] (struct attribute *attr) Tom> + { Tom> + gdb_assert (next_attr_idx <= ARRAY_SIZE (attributes)); This assert is off-by-one so it didn't really check what it was supposed to check. Tom