From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH v2 1/3] gdb: use std::string for internalvar::name
Date: Tue, 14 Feb 2023 13:37:42 -0700 [thread overview]
Message-ID: <87o7pwrnjd.fsf@tromey.com> (raw)
In-Reply-To: <20230214192327.318301-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 14 Feb 2023 14:23:25 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> Change internalvar::name to std::string, automating memory management.
Simon> It becomes necessary to allocate internalvar with new instead of XNEW.
Looks good.
Approved-By: Tom Tromey <tom@tromey.com>
Simon> I didn't find how to trigger the code in complete_internalvar. It is
Simon> called from condition_completer, so it should be by using the
Simon> "condition" command, but I never managed to get in the right code path.
I am not sure either but I believe there's a bug open to the effect that
convenience variable completion does not work.
Tom
prev parent reply other threads:[~2023-02-14 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 19:23 Simon Marchi
2023-02-14 19:23 ` [PATCH v2 2/3] gdb: add constructor to internalvar Simon Marchi
2023-02-14 20:42 ` Tom Tromey
2023-02-15 16:38 ` Simon Marchi
2023-02-15 16:56 ` Tom Tromey
2023-02-15 16:58 ` Simon Marchi
2023-02-14 19:23 ` [PATCH v2 3/3] gdb: store internalvars in an std::map Simon Marchi
2023-02-14 20:46 ` Tom Tromey
2023-02-14 20:37 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7pwrnjd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).