From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id F252A3858D28 for ; Tue, 31 Jan 2023 17:58:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F252A3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 710B310047433 for ; Tue, 31 Jan 2023 17:58:57 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id MuuHpSaKGx7AJMuuHpxJ0G; Tue, 31 Jan 2023 17:58:57 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=WsvujfTv c=1 sm=1 tr=0 ts=63d956e1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=13KGAo4DAAAA:8 a=hUnAMddokqMs7uZh1c0A:9 a=DdAeqqNASC6T8jxox_Jq:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=R5V1j63kIbyZiUgT9fG/uJFIkecnpJitQW4G72y+5vo=; b=Z0gL71qAQ1kRlnNQnfsH3HTOM5 TyKmI/MSdcwtI8HhLGdcuyAKbiIhCOwv6z2YjiTBOhw1P5QkYcQUYjFOMkCSAf1prc2eipLvuSZpk N2jQqpDSS54FfC5IgO3W8V0Gt; Received: from 71-211-157-143.hlrn.qwest.net ([71.211.157.143]:49510 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pMuuH-001pVy-3d; Tue, 31 Jan 2023 10:58:57 -0700 From: Tom Tromey To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Andrew Burgess , Tom Tromey , Richard Bunt Subject: Re: [PATCH v3 1/5] GDB: Ignore `max-value-size' setting with value history accesses References: X-Attribution: Tom Date: Tue, 31 Jan 2023 10:58:55 -0700 In-Reply-To: (Maciej W. Rozycki's message of "Mon, 23 Jan 2023 23:13:08 +0000 (GMT)") Message-ID: <87o7qelh5s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.157.143 X-Source-L: No X-Exim-ID: 1pMuuH-001pVy-3d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-157-143.hlrn.qwest.net (murgatroyd) [71.211.157.143]:49510 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Maciej" == Maciej W Rozycki writes: Maciej> We have an inconsistency in value history accesses where array element Maciej> accesses cause an error for entries exceeding the currently selected Maciej> `max-value-size' setting even where such accesses successfully complete Maciej> for elements located in the inferior, e.g.: Thank you for the patch. gdb has other inconsistencies when using the value history as well. If you print a struct holding a char*, the printers will generally fetch it and print the string. Then if you 'print $3' at some later point, the string will be re-fetched and the new value displayed. Occasionally confusing; it seems to me it would be better for the value history and the printing mechanism to conspire to keep track of all memory read during the printing. Maciej> Moreover a Maciej> statement in documentation says, concerning this setting, that: "Setting Maciej> this variable does not effect values that have already been allocated Maciej> within GDB, only future allocations." While in the implementer-speak Maciej> the sentence may be unambiguous I think the outside user may well infer Maciej> that the setting only applies to values that need to be retrieved from Maciej> the debuggee. Perhaps this could be reworded to mention "values previously computed" or "printed" to tie it better to user actions rather than internal state. Regardless, I think this patch is ok. Tom