From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by sourceware.org (Postfix) with ESMTPS id 199E13858C78 for ; Mon, 30 Jan 2023 21:15:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 199E13858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2a.google.com with SMTP id y2so1449496iot.4 for ; Mon, 30 Jan 2023 13:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=B/7rd2JwfhEGPvpNlpxcJCC0y8hChjGedF0NNPpQkF0=; b=eXsUJ0YeXZV2MRV2lFQMvH47N0MSWoAewSA40hsy14Rqlwdhm+YpVZ4jhV6YXz5btC DjjOwePR0Gb+fGdoqsbzWP3Y/Iu2VsPYVH9LbplOFNGomIlzO+hde8HmagfHTpwL+x5N t9/7JUqeJBmCa+5lXWS7r8xbDLKxEYrxDvD7ZZTOXLcBu8hYn8XLSxiVwM0WbtvrUo3e Q/DCkZjsAIUaGxH8o03fNKL3rEQvYWLpaGRcj7uprNJmkR/Z0PgHBx4uPSjcBYNpJpYG iCNMggYvZpYLWAEVjk4z5sq5Zhwf+L4f6dlRm9FYsdyoeaoLJBVQyWkfeVb2lZxtjMwH v1MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B/7rd2JwfhEGPvpNlpxcJCC0y8hChjGedF0NNPpQkF0=; b=Ye5ayItOessS+p8bq6ejPPuxIJ/L0qVTx1eP5iAFh30YFR4FKEqovsMHHDPasUfOQr gHeJAcQ/9Gj0r8KooC49xJO7CAe0TBRipq759fBzu6VOe2zKyFMfzPZQI9sFAScLygNc v3X1ZRs5sIsNTOoA6TD/86D9JANZaHc6f+ILsv2O0thJ2WbOZBbqok1cwKsZfBmxf+Lc 8/1xm1CeiEYFX5Okm3NFnApZ0iJp1iIVHqHlnHRw72Q/FN4IVV3u74+6vMDJhX3IAdfI Dk+jXabW01IN7/EYNeNLp1La9OwLgIroslkc5bzaReDfc++SGQCAmHyl3is6S0vdJmZ8 b02A== X-Gm-Message-State: AO0yUKUbc6KkE0S6A/nOFaGu95pQjTkKvhu4hv0j8E1g8THZrlRyqqUW fCYQTGj43y8zTrG3mDX2DuBpSkgNEozLlNry X-Google-Smtp-Source: AK7set+ija/5tc/i8TQEGb6+QZhggRYHJf+JZgk5S+UcwprBYCelSBPgf7dr2fVF7AUABZK/QNL36w== X-Received: by 2002:a5e:c117:0:b0:715:9a05:f3d7 with SMTP id v23-20020a5ec117000000b007159a05f3d7mr6500533iol.16.1675113303362; Mon, 30 Jan 2023 13:15:03 -0800 (PST) Received: from murgatroyd (71-211-157-143.hlrn.qwest.net. [71.211.157.143]) by smtp.gmail.com with ESMTPSA id u23-20020a02aa97000000b0039d71c46577sm5194354jai.21.2023.01.30.13.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 13:15:02 -0800 (PST) From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Update the 'g' packet documentation References: <20230111183725.2902496-1-tromey@adacore.com> <533a8893-c0b2-ec5a-fa11-f83bf98f4429@palves.net> <87lem645yr.fsf@tromey.com> X-Attribution: Tom Date: Mon, 30 Jan 2023 14:15:01 -0700 In-Reply-To: (Pedro Alves's message of "Fri, 27 Jan 2023 15:25:33 +0000") Message-ID: <87o7qfn2qy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: Pedro> Here, the new text still uses "collected", but lost the reference to trace frames. Pedro> It seems to me that that will result in people not knowing what "collected" Pedro> means in this context. >> Yeah, I wanted to get rid of the trace frame note, because it's >> confusing -- 'x' can be sent any time, not just a trace frame. Pedro> Yeah, but then people won't know what "collected" here means. Also, in the normal Pedro> case you shouldn't really end up with unavailable registers -- if some register Pedro> really doesn't exist, then the target description should ideally not describe it. While I agree with that, it's also the case that tdep code can reject such a description, and we ran into a case like this in the wild -- where a gdbserver does not report a register, causing i386-tdep to reject the description. However, at one point AdaCore had a port for this target, and that port reported the register but sent back 'x' -- which worked. Also, I wanted to say, I think I misread your first reply. If I'd read it correctly I would have rewritten the text. I'm sorry about that. Pedro> How about this version of the patch? It combines your original patch with Pedro> my suggestions, and also extends it further to describe the normal live target Pedro> scenario and include a remark about just not including the register in the tdesc. Pedro> (Note: I did not add an xref for the target description section at the end because Pedro> there's already one in the preceding paragraph.) This sounds great. Thank you. Tom