From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id EB9403858D28 for ; Tue, 17 Jan 2023 13:53:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB9403858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12e.google.com with SMTP id f8so9314055ilj.5 for ; Tue, 17 Jan 2023 05:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1SrVdb1dDUkfkbq7gAgBx0XroOLERbBqs5cw2HzYw/8=; b=jVNtLNPQLft9VbymZDQzszUmrko3rNtU3fXK5m66z6wKsftjQcpdFG4ToyuGv0gcAc oA39eGlkhRH2kIbV5BFIjIJ4soNsqhKGUJqNfsVB2exhj0bNDVynWQdM6yDpxSgq8ICk 565bNqcIOsdTRCGn1vZX+SQOA5ubVPjdq8GRm0VMT5Yk3zh7wMT6dDDBfvapWs7YZKrV dOZy2Wp7UbIppR5VwFAOFW5lfvOFMaGusQoLXgLVWH2AUceV8x8v1926GabtcCN+Hc7Q r3OtWZyOJ/izOd1MMa2jrSQ16McuxA6ddWIP9qS+bPG8zs30+9yH+zRyg+H53UBWKOhI c6oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1SrVdb1dDUkfkbq7gAgBx0XroOLERbBqs5cw2HzYw/8=; b=ASrT3rraf2ByyOn/hi/MlB2DoCsnB4NwU3/L58o9I+Ui0dGqpM4D1fffidCYm15Mde lLUNlaTaQkEPOmIg/NHwE5gqHVO0QWiDvTArzOnyxBffPeWqW5obxlhXNNgvfmnvaeHO TUOcQzLvIluFnC4htFUDP7TqSg1rQOTMzh2LZAJjjj0VqEqZh4BwATCkk18646yGXX01 /4K4TV3ZRSZsUCr5VIBKxsFA0DjAmKau9l7zuFbOPyH7Atbo9izfL5LhAejHddK0cW8P 63o6EhHDWNa4WqyE6TO+bPHgylkwcDqM4FCwniJvEXTDoGNwEBcJjAffWNMUGE28dCyd i/9A== X-Gm-Message-State: AFqh2kqOmz55EWZ3LEvj7MOV8WPh1UD4kdDbRtWiKflcxSvD37wUePP4 lPRD7mqduSJAVFQY3y04Xi7hyQ== X-Google-Smtp-Source: AMrXdXs77WKwEoI8DysSIbJDGSUuCRPi9jstVGnp/SE7Fh8dZha1FOgz3psTqaya2qC09et910pQyA== X-Received: by 2002:a92:d0ce:0:b0:30b:b982:7632 with SMTP id y14-20020a92d0ce000000b0030bb9827632mr2536793ila.23.1673963614950; Tue, 17 Jan 2023 05:53:34 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id u28-20020a02cb9c000000b0038a49f1d677sm9755265jap.48.2023.01.17.05.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 05:53:34 -0800 (PST) From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey via Gdb-patches , Tom Tromey Subject: Re: [PATCH v2 2/4] Don't erase empty indices in DWARF reader References: <20230110183338.2623088-1-tromey@adacore.com> <20230110183338.2623088-3-tromey@adacore.com> X-Attribution: Tom Date: Tue, 17 Jan 2023 06:53:33 -0700 In-Reply-To: (Joel Brobecker's message of "Sat, 14 Jan 2023 10:05:21 +0400") Message-ID: <87o7qx2roi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Joel" == Joel Brobecker writes: >> The DWARF reader has some code to remove empty indices. However, I >> think this code has been obsolete since some earlier changes to >> parallel_for_each. This patch removes this code. Joel> I don't think this code needs a re-review, since it's already been Joel> approved by me, and I think also by Andrew, but just in case, Joel> OK for me :). Thanks. I think somewhere we discussed the possibility of not merging this patch to gdb-13. I'm planning to leave this one out there, as it's safe to do so. Tom