From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 2B8EE3858D28 for ; Fri, 6 Jan 2023 20:55:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B8EE3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id A3FD61003F8DB for ; Fri, 6 Jan 2023 20:55:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DtkVpAMUFtj39DtkVpue8N; Fri, 06 Jan 2023 20:55:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Xr8/hXJ9 c=1 sm=1 tr=0 ts=63b88ac7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=csriKmy_VF5AMEmuxYAA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KjwUTfu+uX3evXOxfaCyeloiivQ6lkW6AffLmlfCMUQ=; b=SY56roQmFUEyVrr8QvFF40AwQE xXRQ1XjxI+1fDI++GqAxQ5+Akxjt6gIDCOa+cTN/ttMJ/leUdreYiooyBlEfZxkAzXmM3Wneyo7jW AfFszZxjMoTNPG78rZeQWlE+N; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:37206 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pDtkU-000jtR-Qm; Fri, 06 Jan 2023 13:55:34 -0700 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , simark@simark.ca, cbiesinger@google.com, gdb-patches@sourceware.org, luis.machado@arm.com Subject: Re: Two observations using GDB 13 snapshot References: <83h6xugc5v.fsf@gnu.org> <83mt7idacj.fsf@gnu.org> <87fsd4elb2.fsf@tromey.com> <83o7rs4qmg.fsf@gnu.org> <87cz84dasj.fsf@tromey.com> <835ydw20bw.fsf@gnu.org> <87wn6bbi5m.fsf@tromey.com> <83sfgz8m9i.fsf@gnu.org> <87o7rnb0ya.fsf@tromey.com> <83a6368chf.fsf@gnu.org> <87k02aaxc8.fsf@tromey.com> <83wn6a6n21.fsf@gnu.org> <587b899f-0f93-530a-7313-d4e1f9e501b9@simark.ca> <835ydt6jzw.fsf@gnu.org> <83wn63z81w.fsf@gnu.org> <46d7fd4b-d5f0-0007-3e88-20345e0e0584@simark.ca> <831qoayxuu.fsf@gnu.org> <878rii9bg3.fsf@tromey.com> <83fscpxxom.fsf@gnu.org> X-Attribution: Tom Date: Fri, 06 Jan 2023 13:55:30 -0700 In-Reply-To: <83fscpxxom.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Jan 2023 09:11:53 +0200") Message-ID: <87o7rb758d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pDtkU-000jtR-Qm X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (prentzel) [97.122.76.186]:37206 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Eli> Thanks, I applied that patch (modulo the testsuite parts), and I can Eli> confirm that it is almost as fast as the simple one I posted before: Eli> 7.5 sec vs 6.2 sec to read the symbols from gdb.exe. Thank. you Eli> However, what does this change mean in terms of GDB's support for Eli> symbols with non-ASCII names? AFAIU, libiberty's TOLOWER only handles Eli> ASCII characters. This scenario basically doesn't work anyway. We could make it work, probably, but so far there hasn't been much pressure to do that. Eli> If it's okay for GDB to compare case-insensitively only ASCII Eli> characters, then is the above patch mature enough to go to the gdb-13 Eli> branch? I'm going to put my series there soon-ish, either if someone reviews it, or just on my own if not. Tom