From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 6912D3858D35 for ; Thu, 5 Jan 2023 15:08:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6912D3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12b.google.com with SMTP id o13so21089521ilc.7 for ; Thu, 05 Jan 2023 07:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=fkUNc9/f7pH7IJePc4JmredGvYlVhYA6vsUKNIlBvfk=; b=fH1AkpouphkYYTQXe3H2ROt7sjEge93BNpPk8NMK0+D/iME0gq2gQyI+u94gg1l398 lypzCfibdXUwRIsCBu5FmKUkgfJkUHmRXiosyO66/y0i7UEsnIBgfHSEpMreYnqLpTJX qUpQbdCEExr+ep3Ffs6uSsX3fajpBEnj5QRN9jGDly92181JeiZ/HvwlSoBBt4hjm4u/ 2pdTicL0bmD1DpR0oUSm1LAb/Dr6HSDu+19rSfeald2eLuBSx39fKqne1sln5eNWOZm+ OvO9AKiArCpprMb8YW7A7Ge4uJUOyUafLI+xoXRSc1YLMOQM0Cp1A2NlTLWkIV15xkgB TX7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fkUNc9/f7pH7IJePc4JmredGvYlVhYA6vsUKNIlBvfk=; b=HFgUP+Qb4++JUuoYmYrOKx72QAQYQxbg0EtSHP02bHshkDHviMXv7UVljrtxemHf5b CRI8NeNoMGTCBPCidl8D81Djs71AuBUNLySwgT9k4jtlNFntkNYCMFtY9Qrd7HrAyejE rxCCLAYIqaovj0EojDZPCFAzUu2nmAVOfFV5YB6S/Q9Exvm1UtnuGpm1nPwblVooMYVp nkxOtWuGj8k0mmNuNhB59JhOtzQdwVPrq4joX8EsvpefRkHt7CjKUMA0CjU6v2Aan08e dJDbzVVsj7KYL4KE1tRRd+fIZgXucZqvLz6VjQ6DT8Cgf7sz0+dx1viiJ/MzIJ9UzZni AXhw== X-Gm-Message-State: AFqh2kr91k1kqLv+hClxdVHKSrMBjk4cJy416HhgdgkTkuNYJXBND5lg xK9JC0rmGvABQUAPnYESxqmYcyMDXaJuDSmH X-Google-Smtp-Source: AMrXdXtCXgCAr6bpyK/u/M5slyp6MacEKtk6n0sCaqTqmWIUC7H99DgXIyPWDpiRgz8+eUkYUcrstw== X-Received: by 2002:a05:6e02:1c88:b0:30c:e42:f615 with SMTP id w8-20020a056e021c8800b0030c0e42f615mr26756851ill.16.1672931305666; Thu, 05 Jan 2023 07:08:25 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id v9-20020a02b089000000b0038a6da37802sm11878369jah.24.2023.01.05.07.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 07:08:25 -0800 (PST) From: Tom Tromey To: Bruno Larsen Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Add type to expression dump of symbol References: <20230102172813.997882-1-tromey@adacore.com> X-Attribution: Tom Date: Thu, 05 Jan 2023 08:08:24 -0700 In-Reply-To: (Bruno Larsen's message of "Thu, 5 Jan 2023 08:48:42 +0100") Message-ID: <87o7rdf28n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> This is ok, but it would have been handy to see the type of the >> symbol. This ptach adds this information. Bruno> s/ptach/patch Thanks, I fixed that. Bruno> Other than that, seems useful and introduces no regressions, so Bruno> Reviewed-By: Bruno Larsen Thanks again. I'm checking this in. Tom