From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy6-pub.mail.unifiedlayer.com (qproxy6-pub.mail.unifiedlayer.com [69.89.23.12]) by sourceware.org (Postfix) with ESMTPS id 0824638582A3 for ; Sun, 18 Dec 2022 17:48:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0824638582A3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by qproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id D16638028B33 for ; Sun, 18 Dec 2022 17:47:57 +0000 (UTC) Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id BDC9910047439 for ; Sun, 18 Dec 2022 17:46:06 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 6xjipb2SbaMvF6xjipL2u6; Sun, 18 Dec 2022 17:46:06 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=H8Aef8Ui c=1 sm=1 tr=0 ts=639f51de a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=4uRZcBEUBai-KYFVIfgA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kPeX0P5DUj5L/9FjaH2JyzzRn/w6bVAcREOWhW3oA+0=; b=RqqCVJdzvX2fv14+3NmBXwGLcd 8lzkr8pMH22wrPqz19UxTzi4/oqpaMa62fPSni0lOmR+tk+XQa+deJKMwAUKiKGk34raa8hadsExO YIU+4Ar04XPfRsb5F0gsHmH6S; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:59328 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p6xji-001BNB-BU; Sun, 18 Dec 2022 10:46:06 -0700 From: Tom Tromey To: "Metzger, Markus T" Cc: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH 22/46] Use require skip_btrace_tests References: <20221217000818.3729389-1-tom@tromey.com> <20221217000818.3729389-23-tom@tromey.com> X-Attribution: Tom Date: Sun, 18 Dec 2022 10:46:02 -0700 In-Reply-To: (Markus T. Metzger's message of "Sat, 17 Dec 2022 09:22:47 +0000") Message-ID: <87o7s0fvvp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p6xji-001BNB-BU X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (prentzel) [97.122.76.186]:59328 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> +require !skip_btrace_tests > This looks a little bit odd, now, and the ! is easy to miss. Those skip checks > should probably be rewritten as support checks to fit better into the new > require logic. Yes, I think this would be an improvement as well; and if this series goes in, I think we should encourage future predicates to be written in the "positive" sense. > Should this be > require !skip_btrace_tests !use_gdb_stub ... > Same here with skip_gdbserver_tests. These changes are made later in the series, though I didn't make much effort to consistently combine calls to require. Tom