From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 65F183856DC0 for ; Fri, 21 Oct 2022 17:06:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 65F183856DC0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id B97C2100438E7 for ; Fri, 21 Oct 2022 17:06:26 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id lvTWokgYHT2g2lvTWoBXbL; Fri, 21 Oct 2022 17:06:26 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Pds6Ogtd c=1 sm=1 tr=0 ts=6352d192 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=94lacLCJPTnNZ8A47T8A:9 a=bKdfoM6u9_EA:10:demote_shortener_3 a=66zSKFQpzMcA:10:demote_shortener_domain_2 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lermoyY+3yHHEHly6UY3KVh9Q/c4n5P+rZE2cYyvjpU=; b=SJqUKYnzNRbZva6P+PSLkq0Vot nLxH6EPxndNK3ogkDTwQkpdM6UHc9wmPN8p2e7jiamqDwPyebPYKWOtQCe93nHs+kkldmovc/G7xi LvCt7OH/tRJcVE9lrWuXdwaOe; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56746 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1olvTV-003Xju-HT; Fri, 21 Oct 2022 11:06:25 -0600 From: Tom Tromey To: "Rohr, Stephan via Gdb-patches" Cc: Simon Marchi , "Rohr, Stephan" , "tom@tromey.com" Subject: Re: [PATCH 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values casted to different type. References: <20220422144420.3545190-1-stephan.rohr@intel.com> <20220422144420.3545190-2-stephan.rohr@intel.com> <0895de32-0b1b-4053-7a90-21d12fe81b6a@simark.ca> X-Attribution: Tom Date: Fri, 21 Oct 2022 11:06:22 -0600 In-Reply-To: (Stephan via Gdb-patches Rohr's message of "Tue, 11 Oct 2022 08:03:45 +0000") Message-ID: <87o7u5ayy9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1olvTV-003Xju-HT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56746 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 17:06:48 -0000 > I agree here. I will submit a new version of the patch with the extended testcase > and the removed assertion if we conclude that it's safe to remove. BTW there is a bug in bugzilla about this: https://sourceware.org/bugzilla/show_bug.cgi?id=28605 It would be good to mention this in the commit message. Tom