public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Fangrui Song via Gdb-patches <gdb-patches@sourceware.org>
Cc: Alan Modra <amodra@gmail.com>,  Jan Beulich <jbeulich@suse.com>,
	 Nick Clifton <nickc@redhat.com>,
	 Simon Marchi <simon.marchi@polymtl.ca>,
	Fangrui Song <maskray@google.com>,
	 binutils@sourceware.org
Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections
Date: Tue, 27 Sep 2022 12:08:36 -0600	[thread overview]
Message-ID: <87o7v0zo4b.fsf@tromey.com> (raw)
In-Reply-To: <20220923040837.550160-1-maskray@google.com> (Fangrui Song via Gdb-patches's message of "Thu, 22 Sep 2022 21:08:37 -0700")

>>>>> Fangrui Song via Gdb-patches <gdb-patches@sourceware.org> writes:

> PR29397 PR29563: The new configure option --with-zstd defaults to auto.
> If pkgconfig/libzstd.pc is found, define HAVE_ZSTD and support zstd
> compressed debug sections for most tools.

> * bfd: for addr2line, objdump --dwarf, gdb, etc
> * gas: support --compress-debug-sections=zstd
> * ld: support ELFCOMPRESS_ZSTD input and --compress-debug-sections=zstd
> * objcopy: support ELFCOMPRESS_ZSTD input for
>   --decompress-debug-sections and --compress-debug-sections=zstd
> * gdb: support ELFCOMPRESS_ZSTD input.  The bfd change references zstd
>   symbols, so gdb has to link against -lzstd in this patch.

This also needs some change to the sims.
I see failures like this with git master:

make[4]: Entering directory '/home/tromey/gdb/build/sim/bpf'
  CCLD   run
../../bfd/libbfd.a(compress.o):compress.c:function decompress_contents: error: undefined reference to 'ZSTD_decompress'
../../bfd/libbfd.a(compress.o):compress.c:function decompress_contents: error: undefined reference to 'ZSTD_isError'
(unknown):176: error: undefined reference to 'ZSTD_compress'
(unknown):179: error: undefined reference to 'ZSTD_isError'
collect2: error: ld returned 1 exit status

You'll see them all if you do a build with all sims enabled.

thanks,
Tom

  parent reply	other threads:[~2022-09-27 18:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  4:08 Fangrui Song
2022-09-23 14:32 ` Simon Marchi
2022-09-26  5:12   ` Alan Modra
2022-09-26  7:20     ` Fangrui Song
2022-09-26 13:30       ` Alan Modra
2022-09-26 14:08     ` Simon Marchi
2022-09-27  0:33       ` Alan Modra
2022-09-23 15:45 ` Nick Clifton
2022-09-23 15:58   ` Simon Marchi
2022-09-23 18:20     ` Fangrui Song
2022-09-23 18:57       ` Simon Marchi
2022-09-23 20:34         ` Fangrui Song
2022-09-24  5:43           ` Eli Zaretskii
2022-09-24  6:53 ` Enze Li
2022-09-24  7:13   ` Fangrui Song
2022-09-27 18:06     ` Tom Tromey
2022-09-27 18:08 ` Tom Tromey [this message]
2022-09-27 18:53   ` Fangrui Song
2022-09-28 11:52     ` [PATCH] Fix GDB build: ELF support check & -lzstd (was: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections) Pedro Alves
2022-09-28 19:00       ` Simon Marchi
2022-09-28 19:27         ` Pedro Alves
2022-09-28 19:30         ` Fangrui Song
2022-09-29 18:30           ` Pedro Alves
2022-09-29 11:43 ` [PATCH v3] binutils, gdb: support zstd compressed debug sections Martin Liška
2022-09-29 20:17   ` Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7v0zo4b.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=maskray@google.com \
    --cc=nickc@redhat.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).