From: Tom Tromey <tom@tromey.com>
To: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Enze Li <enze.li@hotmail.com>,
schwab@linux-m68k.org, enze.li@gmx.com
Subject: Re: [PATCH v2] gdb: add a numeric check after the exponent (PR cli/24124)
Date: Fri, 23 Sep 2022 07:47:51 -0600 [thread overview]
Message-ID: <87o7v619tk.fsf@tromey.com> (raw)
In-Reply-To: <OS3P286MB215280F9135C41BEDBB2B684F04E9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (Enze Li via Gdb-patches's message of "Thu, 22 Sep 2022 22:09:18 +0800")
>>>>> "Enze" == Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:
>> I suspect the change has to be in c-exp.y:parse_number, in order to
>> support the case where the input radix is 16. In this situation,
Enze> ^^
Enze> Sorry, I didn't get that. Shouldn't this radix be 10?
No, what I mean is:
(gdb) set input-radix 16
Input radix now set to decimal 16, hex 10, octal 20.
(gdb) print 80e
$1 = 2062
I think with your patch this will issue an error.
Enze> In addition, do these test cases below meet expectations?
They seem fine to me.
Tom
next prev parent reply other threads:[~2022-09-23 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 8:36 [PATCH] " Enze Li
2022-09-04 8:42 ` Andreas Schwab
2022-09-04 10:01 ` Enze Li
2022-09-05 13:57 ` [PATCH v2] " Enze Li
2022-09-21 18:12 ` Tom Tromey
2022-09-22 14:09 ` Enze Li
2022-09-23 13:47 ` Tom Tromey [this message]
2022-10-02 12:15 ` Enze Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7v619tk.fsf@tromey.com \
--to=tom@tromey.com \
--cc=enze.li@gmx.com \
--cc=enze.li@hotmail.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).