From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 0A0DE3858C52 for ; Fri, 23 Sep 2022 13:48:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A0DE3858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id D6EEB10042FBE for ; Fri, 23 Sep 2022 13:47:57 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id bj25oHQzWlpGebj25o4kXJ; Fri, 23 Sep 2022 13:47:57 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=I/ag+Psg c=1 sm=1 tr=0 ts=632db90d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=qU0pqOUN05gfR95s5VsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hDL88C/UO+RS237gwgwUGclxJZ6mEH/C//HcnNQ4SHk=; b=L8XVVe2b/4VcRMYNmbBqvScKFE 4w1asKQVN6LQPOIcJiM4gke2WuToAuDleJ4G+9jaR2mhZdk0J70WBRfjeiU5eRsa3Ho+hjcNc8AuT 17mFmwyGBxZzIG8lvWq46MHAc; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56564 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1obj24-001YSE-HE; Fri, 23 Sep 2022 07:47:56 -0600 From: Tom Tromey To: Enze Li via Gdb-patches Cc: Tom Tromey , Enze Li , schwab@linux-m68k.org, enze.li@gmx.com Subject: Re: [PATCH v2] gdb: add a numeric check after the exponent (PR cli/24124) References: <875yhg38bm.fsf@tromey.com> X-Attribution: Tom Date: Fri, 23 Sep 2022 07:47:51 -0600 In-Reply-To: (Enze Li via Gdb-patches's message of "Thu, 22 Sep 2022 22:09:18 +0800") Message-ID: <87o7v619tk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1obj24-001YSE-HE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56564 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2022 13:48:11 -0000 >>>>> "Enze" == Enze Li via Gdb-patches writes: >> I suspect the change has to be in c-exp.y:parse_number, in order to >> support the case where the input radix is 16. In this situation, Enze> ^^ Enze> Sorry, I didn't get that. Shouldn't this radix be 10? No, what I mean is: (gdb) set input-radix 16 Input radix now set to decimal 16, hex 10, octal 20. (gdb) print 80e $1 = 2062 I think with your patch this will issue an error. Enze> In addition, do these test cases below meet expectations? They seem fine to me. Tom