public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb: LoongArch: Fix build errors under cross compile
@ 2022-06-07 13:02 Youling Tang
  2022-06-07 15:48 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Youling Tang @ 2022-06-07 13:02 UTC (permalink / raw)
  To: gdb-patches, tangyouling

When compiling loongarch64 target on x86_64 machine it shows build error
like below:
$ ./confingure --target=loongarch64-linux-gnu
$ make
In file included from ../../gdb/loongarch-linux-tdep.c:23:
../../gdb/gregset.h:27:23: error: ‘gregset_t’ does not name a type; did you mean ‘prgregset_t’?
   27 | #define GDB_GREGSET_T gregset_t
      |                       ^~~~~~~~~
../../gdb/gregset.h:34:9: note: in expansion of macro ‘GDB_GREGSET_T’
   34 | typedef GDB_GREGSET_T gdb_gregset_t;
      |         ^~~~~~~~~~~~~
../../gdb/gregset.h:31:24: error: ‘fpregset_t’ does not name a type; did you mean ‘prfpregset_t’?
   31 | #define GDB_FPREGSET_T fpregset_t
      |                        ^~~~~~~~~~
...

So remove the include of gregset.h file in loongarch-linux-tdep.c.

Signed-off-by: Youling Tang <tangyouling@loongson.cn>
---
 gdb/loongarch-linux-tdep.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/loongarch-linux-tdep.c b/gdb/loongarch-linux-tdep.c
index f6854298569..372643761b1 100644
--- a/gdb/loongarch-linux-tdep.c
+++ b/gdb/loongarch-linux-tdep.c
@@ -20,7 +20,6 @@
 
 #include "defs.h"
 #include "glibc-tdep.h"
-#include "gregset.h"
 #include "inferior.h"
 #include "linux-tdep.h"
 #include "loongarch-tdep.h"
-- 
2.35.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gdb: LoongArch: Fix build errors under cross compile
  2022-06-07 13:02 [PATCH] gdb: LoongArch: Fix build errors under cross compile Youling Tang
@ 2022-06-07 15:48 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2022-06-07 15:48 UTC (permalink / raw)
  To: Youling Tang; +Cc: gdb-patches

>>>>> Youling Tang <tangyouling@loongson.cn> writes:

> When compiling loongarch64 target on x86_64 machine it shows build error
> like below:

This was already fixed by:

commit d9ad47747aacc9326f9e880cbe6077e5c4988456
Author: Roland McGrath <mcgrathr@google.com>
Date:   Thu Jun 2 22:59:23 2022 -0700

    gdb: LoongArch: Remove nonportable #include

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-07 15:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-07 13:02 [PATCH] gdb: LoongArch: Fix build errors under cross compile Youling Tang
2022-06-07 15:48 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).