From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 12581385700D for ; Tue, 31 May 2022 13:53:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 12581385700D Received: by mail-il1-x12b.google.com with SMTP id h18so3513798ilj.7 for ; Tue, 31 May 2022 06:53:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Qh+XFdHMO0j0vxH1Zsy+2B5YPrfaO7FN96bfhYhTJ4w=; b=Mf+3HS5s3du/DE6dCammSojT/kMhCyMxsq8XctOpVBjAwA1rVFMhb/UTHFj6JkJ3CO w4YGi30Z9tBWxNPRNki63ibM6TM3DLjSQ4XSjRGY/pSyELuWxghUyuGdgKu3C8rPTNKV wKF7vwJ3pD13KDdGCRddKOHtcu7iuzvh+OMuSNejPJ4yeT8639zsQyxsuHx+1R53lJEx c5swwsjAZ5/SqZuQ2J5hP87V3NiVvTzNLMPGeUGE04ORtpjevKNjRD7yZRUKX1fj21Ig Yf2/jvyfXXhhgqPpWSeIwyCoA7bE2lyXHxmhWVSUomypR5jORPYvGBFgd9f0WkLiW4QQ 3wcA== X-Gm-Message-State: AOAM531tsWWGiVrCfrCuDOrfFMSnsCRQLTixiok3ZDB43eSsKhQX7ykD x51m3XiIKaWXfoaJ2N/+j6KLnSORJoXt1g== X-Google-Smtp-Source: ABdhPJzciwWNAIFaU9XkFzAWvxcN5urIHmpnNi+wVMC3KEaqz4GeSrpQl75g7cHKEfueuHC82DEj8A== X-Received: by 2002:a92:cf07:0:b0:2d3:a7d3:c795 with SMTP id c7-20020a92cf07000000b002d3a7d3c795mr5641856ilo.104.1654005225385; Tue, 31 May 2022 06:53:45 -0700 (PDT) Received: from murgatroyd (71-211-167-178.hlrn.qwest.net. [71.211.167.178]) by smtp.gmail.com with ESMTPSA id j20-20020a922014000000b002d1d749c8ddsm4566284ile.75.2022.05.31.06.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 06:53:44 -0700 (PDT) From: Tom Tromey To: Enze Li Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Add gdb.current_language function References: <20220527173642.1180218-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 31 May 2022 07:53:43 -0600 In-Reply-To: (Enze Li's message of "Sat, 28 May 2022 23:09:14 +0800") Message-ID: <87o7zd6c60.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 13:53:48 -0000 Enze> I see this patch and don't quite understand why a test case is defined Enze> here but not called. Do we need to execute this newly defined test Enze> case? If not, please ignore my annoying interruptions. Yeah, I just forgot to do that. I added the line now. Tom