From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/2] Avoid undefined behavior in gdbscm_make_breakpoint
Date: Mon, 04 Apr 2022 11:15:08 -0600 [thread overview]
Message-ID: <87o81gixcz.fsf@tromey.com> (raw)
In-Reply-To: <20220404125141.663987-3-pedro@palves.net> (Pedro Alves's message of "Mon, 4 Apr 2022 13:51:41 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> Fix this by parsing the user/guile input as plain int, and cast to
Pedro> internal type only after we know we have a number that would be valid.
This looks good.
Tom
next prev parent reply other threads:[~2022-04-04 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 12:51 [PATCH v2 0/2] Fix a couple undefined behaviors flagged by UBSan Pedro Alves
2022-04-04 12:51 ` [PATCH v2 1/2] gdb: Avoid undefined shifts Pedro Alves
2022-04-04 17:21 ` Tom Tromey
2022-04-04 17:54 ` Pedro Alves
2022-04-04 17:59 ` Tom Tromey
2022-04-04 12:51 ` [PATCH v2 2/2] Avoid undefined behavior in gdbscm_make_breakpoint Pedro Alves
2022-04-04 17:15 ` Tom Tromey [this message]
2022-04-04 19:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o81gixcz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).