From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7E1953858430 for ; Mon, 7 Mar 2022 19:43:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E1953858430 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-YTS43YFKMC-BsuN1rxAyuw-1; Mon, 07 Mar 2022 14:43:52 -0500 X-MC-Unique: YTS43YFKMC-BsuN1rxAyuw-1 Received: by mail-wm1-f69.google.com with SMTP id 14-20020a05600c104e00b003897a167353so44148wmx.8 for ; Mon, 07 Mar 2022 11:43:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=+RKrnA75egTCMccIi26fvDCxYO3YDeZcUi+wiPRIlKQ=; b=escu6UzGWBv1HOMosQVBkkt1Y9KZwAzjIN1Ih0CVe1Aj9GEvygxOppkBtBUjJ/86VP uoEUg75Cj/JDHlLNM5ySqitSumKW4L1Awcr0yKA20Yo0UbQnOBHxCR1WhAy08QcnorCV N+vKZD0xemUI/2tpdv42G9+MD3cPdL31NW3SV0zCLTi7V773Pa2mN+gHfhKwrOLLBuo2 D575F9hV2oSVO6wNC2fHYzn1xhhqIRc7EQpi844LIOHT0G76499TRgZ+0zqwxs+Wy5iL jiKKiMX6UDiH79EVinovwyBj3ikdt+9/EbDa6PqvoxhGRiNtm/nm3/5kOBl4ZvyRCi5z 6U+A== X-Gm-Message-State: AOAM530GeD+IHqSnr28JzKt0cLdCTzXXMFa9N62J67dIB1uWq/W/xrFr /3QNlWLrVysM/qcb2id8m+QdhSuktxudq4aNqTdJhxJEg/zVgn6AMr6SkSMGYml3yZziiWYOQ04 rJH44CcDLjsUNDrhvDVC6ZQ== X-Received: by 2002:adf:f50b:0:b0:1f1:d713:34a1 with SMTP id q11-20020adff50b000000b001f1d71334a1mr9533327wro.506.1646682231075; Mon, 07 Mar 2022 11:43:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxk0x3R+Fu3FWQe43vBvUtVp3V4LWjBARneYedwY1g3h0Y5409C298S6KcWNZIlxaRvtVK+jg== X-Received: by 2002:adf:f50b:0:b0:1f1:d713:34a1 with SMTP id q11-20020adff50b000000b001f1d71334a1mr9533311wro.506.1646682230765; Mon, 07 Mar 2022 11:43:50 -0800 (PST) Received: from localhost (host86-134-151-205.range86-134.btcentralplus.com. [86.134.151.205]) by smtp.gmail.com with ESMTPSA id p2-20020a1c7402000000b0038159076d30sm226067wmc.22.2022.03.07.11.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 11:43:50 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCHv3 0/3] Add Type.is_scalar and Type.is_signed properties In-Reply-To: <877d9ioow4.fsf@tromey.com> References: <877d9ioow4.fsf@tromey.com> Date: Mon, 07 Mar 2022 19:43:49 +0000 Message-ID: <87o82hwnt6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2022 19:43:54 -0000 Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> Thanks for all the feedback on V1, and V2. Additionally, Simon gave > Andrew> some awesome suggestions on IRC > > Andrew> The new V3 series is a complete rewrite, main points are: > > Andrew> - New Type.is_scalar property in patch #1, > > Andrew> - Now have a Type.is_signed property (patch #2), which is either > Andrew> True or False. Attempting to read this property on a non-scalar > Andrew> type will raise a ValueError. > > Andrew> - Finally, patch #3 adds a test for to cover the 'char' is different > Andrew> to 'signed char' and 'unsigned char' issue. This characteristic > Andrew> should be detected by simply comparing types. > > Andrew> Thoughts? > > It all looks reasonable to me. Thank you. I pushed this series. Thanks, Andrew