From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id D23D2385800C for ; Fri, 4 Mar 2022 20:02:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D23D2385800C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 447B010048172 for ; Fri, 4 Mar 2022 20:02:53 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QE8ZnoVpSkku4QE8Zn6NaW; Fri, 04 Mar 2022 20:02:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=SP+H6MjH c=1 sm=1 tr=0 ts=6222706b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=SYs9kpoHHqgMFyjxG8oA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=U4Ik/jhvTZ2xkqS0PSGRWKH5iOH5EeeJBHlswdaxNNQ=; b=hvBJXrur67g/c2F9zidVcZW3Br jDAvCgnxW0Fn/Wp2P3zsDi+JNSenvfLdOSn0wphR6amASm3+fX7OkOZPhsyOwIoefEFDkMbPPSL24 Ovpnenv3SXrHJsopWo4xO/Gz4; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37932 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nQE8Y-000eZn-NR; Fri, 04 Mar 2022 13:02:50 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb: remove unneeded value_address call in value_cast_structs References: <20220216045314.813723-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 04 Mar 2022 13:02:50 -0700 In-Reply-To: <20220216045314.813723-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 15 Feb 2022 23:53:14 -0500") Message-ID: <87o82lqydx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nQE8Y-000eZn-NR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37932 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 20:02:55 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> - addr2 -= value_address (v) + value_embedded_offset (v); Simon> + addr2 -= value_embedded_offset (v); Thank you. I appreciated your long commentary. I think this is ok, especially if it passed the gdb.cp tests :) Sometimes I wonder if we could get rid of all this "embedded offset" stuff. It's an endless source of confusion, at least for me. Tom