From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.36]) by sourceware.org (Postfix) with ESMTPS id 7BBB8388E80D for ; Wed, 28 Jul 2021 21:27:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BBB8388E80D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id B7A22859EE3 for ; Wed, 28 Jul 2021 15:27:34 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8q9OmHM4uK61i8q9OmQdAK; Wed, 28 Jul 2021 15:27:34 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UdvGPFyw6u2C75TzHxfa3Q7wOHUb2pPGlYrsL9f42Ks=; b=oB6v80Pr1bUbM5+zGc8XAvCuTe mTihL8QiFrmRxZxW6D1TWv/Jngs/bhwYUKeOsTUNE87sbK+NfR0Z2Af4dtniCUq6qru/6opsK+Jwk hoNj03ZxsWVfgqeJs++Ab2/CF; Received: from 97-122-74-117.hlrn.qwest.net ([97.122.74.117]:35986 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m8q9O-003A8K-D4; Wed, 28 Jul 2021 14:27:34 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 16/16] gdb: make string-like set show commands use std::string variable References: <20210714045520.1623120-1-simon.marchi@polymtl.ca> <20210714045520.1623120-17-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Wed, 28 Jul 2021 14:27:33 -0600 In-Reply-To: <20210714045520.1623120-17-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Wed, 14 Jul 2021 00:55:20 -0400") Message-ID: <87o8amchfu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.74.117 X-Source-L: No X-Exim-ID: 1m8q9O-003A8K-D4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-74-117.hlrn.qwest.net (murgatroyd) [97.122.74.117]:35986 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 21:27:33 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> String-like settings (var_string, var_filename, var_optional_filename, Simon> var_string_noescape) currently take a pointer to a `char *` storage Simon> variable (typically global) that holds the setting's value. I'd like to Simon> "mordernize" this by changing them to use an std::string for storage. It seems like a decent idea to me. I didn't go through the patch. I imagine it's mostly fairly mechanical transforms. Simon> The add_path function in source.c is really complex and twisted, I'd Simon> rather not try to change it to work on an std::string right now. Simon> Instead, I added an overload that copies the std:string to a `char *` Simon> and back. This means more copying, but this is not used in a hot path Simon> at all, so I think it is acceptable. That seems fine. It might be nice if we had a way to track these little cleanup items. Maybe a tag in bugzilla. I suppose the main danger of this patch is lingering old-style variables in code you couldn't build, say some of the less-supported native targets. But, we usually handle those on a best-effort basis anyway. And, maybe they don't use this feature. Tom