From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.142]) by sourceware.org (Postfix) with ESMTPS id 5F0FF3844041 for ; Thu, 11 Mar 2021 21:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F0FF3844041 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 4CBE312B69 for ; Thu, 11 Mar 2021 15:26:26 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KSp8ljDL24HRaKSp8lfUkL; Thu, 11 Mar 2021 15:26:26 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rE+POLOEy6un95rg3G/0cLyxVFh4RxdBZLb0LlG/VX0=; b=Oe+hsUUU0h7idzawNqJEgCY8T1 3RImNiEw7FUmRV6s4qy+3FRVeM0Kq6mLoXiRMTFYUapZVotKkzulyh1cYBNMlvZF7+DakRwGzXkPQ PffacKzGnuwSbtrFkYhaKc6Z0; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:35534 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lKSp7-000S3M-VL; Thu, 11 Mar 2021 14:26:26 -0700 From: Tom Tromey To: Andrew Burgess Cc: Hannes Domani , gdb-patches@sourceware.org Subject: Re: [PATCH 05/22] Implement locals TUI window References: <20210306173417.21528-1-ssbssa@yahoo.de> <20210306173417.21528-6-ssbssa@yahoo.de> <20210308095133.GK1720904@embecosm.com> X-Attribution: Tom Date: Thu, 11 Mar 2021 14:26:25 -0700 In-Reply-To: <20210308095133.GK1720904@embecosm.com> (Andrew Burgess's message of "Mon, 8 Mar 2021 09:51:33 +0000") Message-ID: <87o8fp5qm6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lKSp7-000S3M-VL X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:35534 X-Source-Auth: tom+tromey.com X-Email-Count: 15 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 21:26:31 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> I'm not sure we need to limit ourselves to 80 characters as in GDB, Andrew> but I think some of your lines in this file are too long. My Andrew> preference would be target 80 wherever possible, but set a hard limit Andrew> of, maybe 100. However, this is just my opinion, not a general GDB Andrew> policy, so others might disagree. For the Python code in particular, I've been planning to propose we switch to the 'black' code formatter, and just require running (some specific version of) this on every .py change. Then we wouldn't have to review Python style at all. Tom