From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.229]) by sourceware.org (Postfix) with ESMTPS id 5FD103860C39 for ; Mon, 14 Dec 2020 21:35:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5FD103860C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id CD2749D01 for ; Mon, 14 Dec 2020 15:35:07 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ovUpkX6F9HPnUovUpko37W; Mon, 14 Dec 2020 15:35:07 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o5b8RY2XIQHC9FuYusLM9rY0Ci3tDgxKGMy9alRjvdA=; b=pwXUHkRl/UR171bmBs4J4rzufX 3a9Ejn+PIm9353jCLAU2f0g/hq/4GeUgqleSwXPRXtjWInRBLr5ArevEByRfexZryaUl6+f9Kem4Z mBK4xT6TeHaCWB6QvAR5NaMFN; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:45874 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kovUo-002McS-W0; Mon, 14 Dec 2020 14:35:07 -0700 From: Tom Tromey To: Simon Marchi Cc: Bernd Edlinger , Joel Brobecker , Pedro Alves , Eli Zaretskii , Andrew Burgess , "gdb-patches@sourceware.org" Subject: Re: [PATCH v2] Enable GDB build with in-tree GMP and MPFR References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> <1605429345-78384-1-git-send-email-brobecker@adacore.com> <1605429345-78384-2-git-send-email-brobecker@adacore.com> <20201116034518.GA609903@adacore.com> <20201118034455.GE617116@adacore.com> <71f5437f-c4f5-b58d-06f7-67a4d0b31007@simark.ca> <214e9564-5dfd-65a2-c2d8-6e8398ebc913@simark.ca> X-Attribution: Tom Date: Mon, 14 Dec 2020 14:35:06 -0700 In-Reply-To: <214e9564-5dfd-65a2-c2d8-6e8398ebc913@simark.ca> (Simon Marchi's message of "Mon, 14 Dec 2020 13:47:37 -0500") Message-ID: <87o8iw9ilx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kovUo-002McS-W0 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:45874 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2020 21:35:10 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> So with this patch, we now have: Simon> --with-gmp-include=DIR GMP include directory Simon> --with-gmp-lib=DIR GMP lib directory Simon> --with-gmp=DIR GMP install directory Simon> --with-libgmp-prefix[=DIR] search for libgmp in DIR/include and DIR/lib Simon> --without-libgmp-prefix don't search for libgmp in includedir and libdir Simon> I think that's getting a bit confusing. That's too many ways to set gmp Simon> paths, with -with-libgmp-prefix and --with-gmp doing the same thing. FWIW we have the same situation with MPFR. Simon> It might mean that we have to stop using AC_LIB_HAVE_LINKFLAGS Simon> though, or customize it. Yes. Perhaps alternatively we could promote its use to the top level. It's maybe a pain to do that. Simon> An alternative to downloading the pre-requisites would be to check them Simon> in the repo. We do it for readline already: there is a copy in the Simon> repo, which is used by default, but you can specify Simon> --with-system-readline if you want to use the system's readline. We Simon> could do the same with gmp and mpfr. The downside is that we deviate a Simon> bit from how gcc does, the the upside is that it's simpler, IMO. For me the main difference here is that, historically, we've had to patch readline. In cases where GDB has never needed to patch a dependency (libiconv comes to mind), we've haven't bothered. Tom