From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 0E0A03857C48 for ; Wed, 2 Sep 2020 18:45:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0E0A03857C48 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B4BF611751D; Wed, 2 Sep 2020 14:45:45 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id siRo4-x3hBKQ; Wed, 2 Sep 2020 14:45:45 -0400 (EDT) Received: from murgatroyd (97-118-98-94.hlrn.qwest.net [97.118.98.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 57822117242; Wed, 2 Sep 2020 14:45:45 -0400 (EDT) From: Tom Tromey To: Tom Tromey Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Further simplify gdb BFD caching References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-4-tromey@adacore.com> <871rrpsub2.fsf@tromey.com> X-Attribution: Tom Date: Wed, 02 Sep 2020 12:45:44 -0600 In-Reply-To: <871rrpsub2.fsf@tromey.com> (Tom Tromey's message of "Thu, 23 Jan 2020 15:05:05 -0700") Message-ID: <87o8mouief.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2020 18:45:47 -0000 Tom> gdb/ChangeLog Tom> 2020-01-14 Tom Tromey Tom> * gdb_bfd.c (gdb_bfd_data): Remove "mt" parameter, add "st" Tom> parameter. Don't call bfd_stat. Tom> (gdb_bfd_init_data): Replace "mt" parameter with "st". Tom> (gdb_bfd_open): Rearrange and update. Tom> (gdb_bfd_ref): Call bfd_stat. Tom> This probably has to be merged into an earlier patch, because the eq_bfd Tom> function checks these other fields as well. I may end up just squashing Tom> the whole series, we'll see... but I won't do anything until the stat Tom> problem has a solution. I've merged patches #1 and #3 from this series. I think the result is correct regardless of how the stat issue is fixed, so soon I'm going to submit it separately. Tom