From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/ada] Fix -readnow FAILs
Date: Wed, 01 Apr 2020 12:30:51 -0600 [thread overview]
Message-ID: <87o8sb2h44.fsf@tromey.com> (raw)
In-Reply-To: <20200324070749.GA30240@delia> (Tom de Vries's message of "Tue, 24 Mar 2020 08:07:51 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> 2020-03-24 Tom de Vries <tdevries@suse.de>
Tom> PR ada/24671
Tom> * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
Thank you. I think this is ok.
Now that we have lookup_name_info, I wonder if map_matching_symbols can
be removed entirely and replaced with expand_symtabs_matching.
Tom> + if (dwarf2_per_objfile->index_table)
This should use "!= nullptr".
Tom
prev parent reply other threads:[~2020-04-01 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 7:07 Tom de Vries
2020-04-01 18:30 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8sb2h44.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).