From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56798 invoked by alias); 14 Dec 2019 04:50:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56790 invoked by uid 89); 14 Dec 2019 04:50:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1464 X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Dec 2019 04:50:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576299055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uVlF1aKrKN372uWoJ/RWr2i6yjM+EvqAwHcVYFy7HPE=; b=d0yT6QcLNhalubjC+nhM5ox2ZhArFActnY5Ohj66YBUQShHdBMkuYwNJ1EBszp5vhU6Usm 3r3+L328d4DjvmKUpVKXIIGdCjPxVwMNS393r9SEdfQcBA3FuaYkPYLMEzNuvrdTCkfYwD vwul7ESRObNx3f83+SUsba8O7OVSWWw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-HhTSno5jNsOFP0BaxUQI0Q-1; Fri, 13 Dec 2019 23:50:50 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7A18477; Sat, 14 Dec 2019 04:50:48 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB2D219756; Sat, 14 Dec 2019 04:50:48 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: GDB Patches Subject: Re: [PATCH v2] Guard against 'current_directory == NULL' on gdb_abspath (PR gdb/23613) References: <20190710234615.14800-1-sergiodj@redhat.com> <20191121193729.26315-1-sergiodj@redhat.com> <87k16zvp9t.fsf@tromey.com> Date: Sat, 14 Dec 2019 04:50:00 -0000 In-Reply-To: <87k16zvp9t.fsf@tromey.com> (Tom Tromey's message of "Fri, 13 Dec 2019 15:23:10 -0700") Message-ID: <87o8wbwlw7.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00653.txt.bz2 On Friday, December 13 2019, Tom Tromey wrote: >>>>>> "Sergio" =3D=3D Sergio Durigan Junior writes: > > Sergio> gdb/ChangeLog: > Sergio> 2019-11-21 Sergio Durigan Junior > > Sergio> https://bugzilla.redhat.com/show_bug.cgi?id=3D1728147 > Sergio> PR gdb/23613 > Sergio> * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'. > Sergio> * corelow.c: Include 'gdbsupport/pathstuff.h'. > Sergio> (core_target_open): Use 'gdb_abspath'. > Sergio> * gdbsupport/pathstuff.c (gdb_abspath): Guard against > Sergio> 'current_directory =3D=3D NULL' case. > Sergio> * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and > Sergio> explain what happens when 'current_directory' is NULL. > Sergio> * go32-nat.c (go32_nat_target::wait): Check if > Sergio> 'current_directory' is NULL before call to 'chdir'. > Sergio> * source.c (add_path): Use 'gdb_abspath'. > Sergio> * top.c: Include 'gdbsupport/pathstuff.h'. > Sergio> (init_history): Use 'gdb_abspath'. > Sergio> (set_history_filename): Likewise. > Sergio> * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'. > Sergio> (tfile_target_open): Use 'gdb_abspath'. > > Thanks. This is ok. Thanks for the review, Tom. Pushed: ff8577f64987a898e1dc5eb6afb66a404fb7bb16 --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/