From: Tom Tromey <tom@tromey.com>
To: Matt Rice <ratmice@gmail.com>
Cc: "Simon Marchi \(Code Review\)"
<gerrit@gnutoolchain-gerrit.osci.io>,
Tom Tromey <tromey@sourceware.org>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [review] Style diassembly in the TUI
Date: Wed, 30 Oct 2019 23:11:00 -0000 [thread overview]
Message-ID: <87o8xxn81d.fsf@tromey.com> (raw)
In-Reply-To: <CACTLOFoWqD7vcVns80Y2xiOK06YJ7=AoDWn4HnM7XwuETon-sA@mail.gmail.com> (Matt Rice's message of "Wed, 30 Oct 2019 21:13:35 +0000")
>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:
Matt> I believe there must be something in the extended-prompt code,
Matt> which implements \[ \] for excluding escape sequences from the length.
This works in a different way and is kind of readline-specific.
I went ahead and just implemented the necessary function in the 2nd
revision of the patch.
Tom
next prev parent reply other threads:[~2019-10-30 23:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 17:29 Tom Tromey (Code Review)
2019-10-21 22:16 ` Simon Marchi (Code Review)
2019-10-22 1:25 ` Tom Tromey (Code Review)
2019-10-22 4:27 ` Simon Marchi (Code Review)
2019-10-30 21:13 ` Matt Rice
2019-10-30 23:11 ` Tom Tromey [this message]
2019-10-23 14:00 ` [review v2] " Tom Tromey (Code Review)
2019-10-23 14:22 ` Tom Tromey (Code Review)
2019-10-30 19:30 ` Simon Marchi (Code Review)
2019-10-30 22:56 ` [review v3] Style disassembly " Tom Tromey (Code Review)
2019-11-05 22:23 ` Tom Tromey (Code Review)
2019-11-05 22:36 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-05 22:36 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8xxn81d.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=gerrit@gnutoolchain-gerrit.osci.io \
--cc=ratmice@gmail.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).