From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90134 invoked by alias); 13 Feb 2019 13:47:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90101 invoked by uid 89); 13 Feb 2019 13:47:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:320 X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.162) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Feb 2019 13:47:13 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 8F2DC2EB39 for ; Wed, 13 Feb 2019 07:47:11 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id tusZgHlDE4FKptusZgcKfZ; Wed, 13 Feb 2019 07:47:11 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2d0ySQpDGySfZdmVsG4HuVfSSoJfFgv1PC+89xjFB28=; b=m7oaSKtSu1e0KeSBCTE/pL935k YPFGFZBzXMYvc774ql3QRDW5aQVA5uR+e1ui0oXz+vHXn59yf/iBAkHciELFE7ABGNAm2g/rqP5Vi zk4hbK60RBW8YfvzO+a1JcoQD; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:36754 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gtusZ-004BCL-9f; Wed, 13 Feb 2019 07:47:11 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Fix leaks in ada catch command References: <20190211053728.7668-1-philippe.waroquiers@skynet.be> <87bm3g7krk.fsf@tromey.com> <1550008530.1438.10.camel@skynet.be> Date: Wed, 13 Feb 2019 13:47:00 -0000 In-Reply-To: <1550008530.1438.10.camel@skynet.be> (Philippe Waroquiers's message of "Tue, 12 Feb 2019 22:55:30 +0100") Message-ID: <87o97f6bs1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00180.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> Yes, your suggestions to use std::string * and the below patch seem Philippe> better to me. So, I assume you will push fixes for both I've sent the patches now, please take a look. Tom