From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34066 invoked by alias); 4 Oct 2018 12:44:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34052 invoked by uid 89); 4 Oct 2018 12:44:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Oct 2018 12:44:17 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id C8A48D257 for ; Thu, 4 Oct 2018 07:44:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 82yzgc8sfRPoj82zAgvM91; Thu, 04 Oct 2018 07:44:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JxrzN77nWpw/PYrJMj96sCb5macvvXj7j8e4oGesZuk=; b=dvzNy2cIONImqf5XLBUfpCCagH B/HR2ZHoYgrdqMQOX2jMDKP3WP18S/YD2loE2YGq9Yuf7qDaJgg0jN534risr5ctoz2cW8WfI61Ub LfY0IGfLLOu7FkG/uDTCYvTYn; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:50286 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g82yz-003env-3G; Thu, 04 Oct 2018 07:43:57 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , "gdb-patches\@sourceware.org" Subject: Re: [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var References: <20180923040814.27941-1-tom@tromey.com> <20180923040814.27941-8-tom@tromey.com> <6d098a36-c483-77b8-61a6-87768c29f5d5@ericsson.com> Date: Thu, 04 Oct 2018 12:44:00 -0000 In-Reply-To: <6d098a36-c483-77b8-61a6-87768c29f5d5@ericsson.com> (Simon Marchi's message of "Wed, 3 Oct 2018 16:12:04 +0000") Message-ID: <87o9c9j303.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00106.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-09-23 12:08 AM, Tom Tromey wrote: >> -Wshadow=local pointed out that the shadowing in gdbscm_frame_read_var >> means that the ultimate call to read_var_value will always be passed >> block==NULL. The fix is to remove the outer declaration. Simon> s/outer/inner/ ? Yes, thanks. I've updated the commit message. Tom