From: Tom Tromey <tom@tromey.com>
To: Wei-min Pan <weimin.pan@oracle.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH PR gdb/16841] virtual inheritance via typedef cannot find base
Date: Tue, 31 Jul 2018 15:42:00 -0000 [thread overview]
Message-ID: <87o9en4dkg.fsf@tromey.com> (raw)
In-Reply-To: <8147f44e-5deb-9f32-76b1-ead651975961@oracle.com> (Wei-min Pan's message of "Mon, 30 Jul 2018 10:58:28 -0700")
>>>>> ">" == Wei-min Pan <weimin.pan@oracle.com> writes:
Tom> I think the loop limit should be TYPE_N_BASECLASSES.
>> OK, will change it to TYPE_N_BASECLASSES. BTW, there are quite a
>> number of places that use:
>> for (i = 0; i < TYPE_NFIELDS (type); ++i)
Yes, it just depends on whether the intent at a given spot is to loop
over all fields, or to only loop over base classes.
Tom
next prev parent reply other threads:[~2018-07-31 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 23:50 Weimin Pan
2018-07-24 22:18 ` Simon Marchi
2018-07-24 23:26 ` Weimin Pan
2018-07-29 2:28 ` Tom Tromey
2018-07-30 17:58 ` Wei-min Pan
2018-07-31 15:42 ` Tom Tromey [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-15 23:45 Weimin Pan
2018-06-17 1:06 ` Simon Marchi
2018-06-18 16:12 ` Wei-min Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9en4dkg.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).