From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16459 invoked by alias); 1 Mar 2018 19:50:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16449 invoked by uid 89); 1 Mar 2018 19:50:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 19:50:21 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8968040FB657; Thu, 1 Mar 2018 19:50:19 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 472FC2026E04; Thu, 1 Mar 2018 19:50:19 +0000 (UTC) From: Sergio Durigan Junior To: Christophe Lyon Cc: Joel Brobecker , GDB Patches , Simon Marchi , Pedro Alves Subject: Re: [PATCH v3 0/2] Make gdbserver work with filename-only binaries References: <20180210014241.19278-3-sergiodj@redhat.com> <20180228032708.19670-1-sergiodj@redhat.com> <87sh9ka5ze.fsf@redhat.com> <20180301025528.zyh5m5jls45t3ooa@adacore.com> Date: Thu, 01 Mar 2018 19:50:00 -0000 In-Reply-To: (Christophe Lyon's message of "Thu, 1 Mar 2018 14:08:05 +0100") Message-ID: <87o9k78tj8.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00038.txt.bz2 On Thursday, March 01 2018, Christophe Lyon wrote: > On 1 March 2018 at 03:55, Joel Brobecker wrote: >>> Simon reminded me that this patch is also a good fit for the 8.1 branch, >>> so I went ahead and pushed it there. >>> >>> 506817a3abd98859eb3474389e756c0253cc28a1 >>> 2441702a72f324e41a1624dc042b334f375e2d81 >>> 6d607b8812b35ff36fbbad2915696f6669f86a32 >> > > Hi, > > These new patches seem to cause problems with building for ming (using > i686-w64-mingw32-g++): I'm taking a look at this right now. Thanks for reporting. > /gdb/common/pathstuff.c: In function 'gdb::unique_xmalloc_ptr > gdb_realpath(const char*)': > /gdb/common/pathstuff.c:56:14: error: 'MAX_PATH' was not declared in this scope > char buf[MAX_PATH]; > ^ > /gdb/common/pathstuff.c:57:5: error: 'DWORD' was not declared in this scope > DWORD len = GetFullPathName (filename, MAX_PATH, buf, NULL); > ^ > /gdb/common/pathstuff.c:57:11: error: expected ';' before 'len' > DWORD len = GetFullPathName (filename, MAX_PATH, buf, NULL); > ^ > /gdb/common/pathstuff.c:63:9: error: 'len' was not declared in this scope > if (len > 0 && len < MAX_PATH) > ^ > /gdb/common/pathstuff.c:64:54: error: 'buf' was not declared in this scope > return gdb::unique_xmalloc_ptr (xstrdup (buf)); > ^ > make[2]: *** [pathstuff.o] Error 1 > > I saw this while rebuilding branch 8.1, I didn't check master. > > Sorry if this has already been reported, I can't find any mention of > this problem in the list archives. > > I suspect there's already a recommended way of handling MAX_PATH cross-platform. > > Thanks > > Christophe > >> Thanks for getting this through, Sergio and Simon. >> >> Just a quick reminder that, now that the .0 is out, all new patches >> pushed on the branch should have a corresponding PR number, with >> the target milestone set to 8.1. This is to be able to give users >> an actionable list of PRs they can look at if they are wondering >> what the difference between 8.0 and 8.1 is. Is there one for this >> issue? If not, it's good enough to create one after the fact, as >> long as the PR points to the various discussions and maybe gives >> the SHA1 of the various commits, I think we're good. >> >> Thank you! >> -- >> Joel -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/