From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23895 invoked by alias); 15 Dec 2017 20:11:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23881 invoked by uid 89); 15 Dec 2017 20:11:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Dec 2017 20:11:44 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3A17C4E918; Fri, 15 Dec 2017 20:11:43 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3C6460176; Fri, 15 Dec 2017 20:11:42 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Cc: Tom Tromey , Eli Zaretskii , Simon Marchi , Pedro Alves , Keith Seitz Subject: Re: [PATCH v7 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg) References: <20171121160709.23248-1-sergiodj@redhat.com> <20171215011247.7396-1-sergiodj@redhat.com> Date: Fri, 15 Dec 2017 20:11:00 -0000 In-Reply-To: <20171215011247.7396-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Thu, 14 Dec 2017 20:12:45 -0500") Message-ID: <87o9mzrbsx.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00393.txt.bz2 On Thursday, December 14 2017, I wrote: > Changes from v6: > > - Updated examples in the documentation. > > - Removed stale comments about the test being x86_64-specific from > tests. > > - Added tests for "ptype /oTM", "ptype /TMo", and for the regression > Pedro caught. > > - Removed "print_offset_default_data". > > - Fixed regression reported by Pedro. > > - s/endpos/end_bitpos/ > > - Filtered out the languages that don't implement the feature so that > their type printing output doesn't get clobbered by "ptype /o" when > they use "common" code (which is not actually common; it lives > inside c-typeprint.c). I decided to do that by checking the current > language on typeprint.c:whatis_exp, before setting the > "print_offset" bit. > > > The documentation parts have been approved by Eli, and haven't > changed. Patches have been pushed: a27ed7d613ec91c3a79965d6bdab1fa96d559c85 7c1618381fdaa0697a211721ac31844f884797ac Thanks for all the help with reviews and suggestions. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/