From: Tom Tromey <tom@tromey.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA 4/8] Make strip_bg_char return a unique_xmalloc_ptr
Date: Wed, 18 Oct 2017 03:32:00 -0000 [thread overview]
Message-ID: <87o9p5rv0h.fsf@tromey.com> (raw)
In-Reply-To: <867evuvxug.fsf@gmail.com> (Yao Qi's message of "Tue, 17 Oct 2017 12:05:11 +0100")
>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
Yao> Yes, that is one approach I though of, but it needs changing code. I am
Yao> looking at running gdb testsuite with valgrind, but there are too many
Yao> warnings on leak, so it is not that useful to find new leaks.
That sounds pretty bad.
A valgrind or ASAN buildbot would be good...
Yao> The patch is the good direction to go, so I don't want to block it.
Yao> Meanwhile, I am still looking at memory leaks reported by valgrind.
I don't know if the cleanup checker still works, but that would be one
route. I don't believe there are all that many dangling cleanups any
more, but I do agree that it's hard to know.
It's maybe worth pointing out that, at least in the past (I didn't look
recently), commands were always run with a cleanup installed, and this
cleanup was run after the command returned. So, before the cleanup
checker work, it was normal to see dangling cleanups in command
implementations. If this still exists then I think it would reduce the
risk of changing strip_bg_char.
Tom
next prev parent reply other threads:[~2017-10-18 3:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 21:00 [RFA 0/8] Constify many commands Tom Tromey
2017-10-13 21:00 ` [RFA 2/8] Constify add_com_suppress_notification Tom Tromey
2017-10-16 9:03 ` Yao Qi
2017-10-16 15:55 ` Tom Tromey
2017-10-13 21:00 ` [RFA 8/8] Constify add_com Tom Tromey
2017-10-16 9:59 ` Yao Qi
2017-10-13 21:00 ` [RFA 6/8] Remove cleanup from backtrace_command Tom Tromey
2017-10-16 9:46 ` Yao Qi
2017-10-13 21:00 ` [RFA 1/8] Constify add_abbrev_prefix_cmd Tom Tromey
2017-10-16 9:02 ` Yao Qi
2017-10-16 15:54 ` Tom Tromey
2017-10-16 20:23 ` Yao Qi
2017-10-13 21:00 ` [RFA 7/8] Add truncate_repeat_arguments function Tom Tromey
2017-10-14 4:49 ` Tom Tromey
2017-10-16 3:07 ` Tom Tromey
2017-10-16 9:53 ` Yao Qi
2017-10-18 3:48 ` Tom Tromey
2017-11-06 16:38 ` Tom Tromey
2017-11-07 14:35 ` Pedro Alves
2017-10-13 21:00 ` [RFA 5/8] Constify add_path and friends Tom Tromey
2017-10-16 9:35 ` Yao Qi
2017-10-13 21:00 ` [RFA 4/8] Make strip_bg_char return a unique_xmalloc_ptr Tom Tromey
2017-10-16 9:33 ` Yao Qi
2017-10-16 18:37 ` Simon Marchi
2017-10-17 11:05 ` Yao Qi
2017-10-18 3:32 ` Tom Tromey [this message]
2017-10-18 9:37 ` Pedro Alves
2017-11-06 16:33 ` Tom Tromey
2017-10-13 21:00 ` [RFA 3/8] Make set_cmd_cfunc private Tom Tromey
2017-10-16 9:20 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9p5rv0h.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).