From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36752 invoked by alias); 11 Mar 2015 18:15:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36740 invoked by uid 89); 11 Mar 2015 18:15:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 11 Mar 2015 18:15:51 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2BIFnmb029270 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Mar 2015 14:15:49 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2BIFlfB023354 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 11 Mar 2015 14:15:48 -0400 From: Sergio Durigan Junior To: Yao Qi Cc: GDB Patches Subject: Re: [PATCH 2/2] Create gdb/break-catch-syscall.c References: <1426030105-15485-1-git-send-email-sergiodj@redhat.com> <1426030105-15485-3-git-send-email-sergiodj@redhat.com> <86ioe7hirx.fsf@gmail.com> X-URL: http://blog.sergiodj.net Date: Wed, 11 Mar 2015 18:15:00 -0000 In-Reply-To: <86ioe7hirx.fsf@gmail.com> (Yao Qi's message of "Wed, 11 Mar 2015 11:32:02 +0000") Message-ID: <87oanzqu24.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00311.txt.bz2 On Wednesday, March 11 2015, Yao Qi wrote: > Sergio Durigan Junior writes: > > Hi Sergio, > Thanks for doing this. I felt compelled after your patch :-). >> Tested by running the 'gdb.base/catch-syscall.exp' testcase. >> > > Could you please run the whole testsuite? it shouldn't take much time. > If it is regression free, the patch is fine by me, with the following > typo fixed, Sure thing. I rand the testsuite and the results are fine. >> gdb/ChangeLog: >> 2015-03-10 Sergio Durigan Junior >> >> * Makefile.in (SFILES): New object break-catch-syscall.o. > > It should be break-catch-syscall.c Ops, thanks for catching this! Fixed. >> (COMMON_OBS): Likewise. >> * break-catch-syscall.c: New file. >> * breakpoint.c: Remove inclusion of "xml-syscall.h". >> (syscall_catchpoint_p): Move declaration to break-catch-syscall.c >> (struct syscall_catchpoint): Likewise. >> (dtor_catch_syscall): Likewise. >> (catch_syscall_inferior_data): Likewise. >> (struct catch_syscall_inferior_data): Likewise. >> (get_catch_syscall_inferior_data): Likewise. >> (catch_syscall_inferior_data_cleanup): Likewise. >> (insert_catch_syscall): Likewise. >> (remove_catch_syscall): Likewise. >> (breakpoint_hit_catch_syscall): Likewise. >> (print_it_catch_syscall): Likewise. >> (print_one_catch_syscall): Likewise. >> (print_mention_catch_syscall): Likewise. >> (print_recreate_catch_syscall): Likewise. >> (catch_syscall_breakpoint_ops): Likewise. >> (syscall_catchpoint_p): Likewise. >> (create_syscall_event_catchpoint): Likewise. >> (catch_syscall_split_args): Likewise. >> (catch_syscall_command_1): Likewise. >> (is_syscall_catchpoint_enabled): Likewise. >> (catch_syscall_enabled): Likewise. >> (catching_syscall_number): Likewise. >> (catch_syscall_completer): Likewise. >> (clear_syscall_counts): Likewise. >> (initialize_breakpoint_ops): Move initialization of syscall >> catchpoints to break-catch-syscall.c. >> (_initialize_breakpoint): Move code related to syscall catchpoints >> to break-catch-syscall.c. >> --- >> gdb/Makefile.in | 2 + >> gdb/break-catch-syscall.c | 659 ++++++++++++++++++++++++++++++++++++++++++++++ >> gdb/breakpoint.c | 600 ----------------------------------------- >> 3 files changed, 661 insertions(+), 600 deletions(-) >> create mode 100644 gdb/break-catch-syscall.c >> >> diff --git a/gdb/Makefile.in b/gdb/Makefile.in >> index 8c2a4de..f59ad66 100644 >> --- a/gdb/Makefile.in >> +++ b/gdb/Makefile.in >> @@ -816,6 +816,7 @@ SFILES = ada-exp.y ada-lang.c ada-typeprint.c ada-valprint.c ada-tasks.c \ >> bfd-target.c \ >> block.c blockframe.c \ >> breakpoint.c break-catch-sig.c break-catch-throw.c \ >> + break-catch-syscall.o \ > > Likewise. Fixed. Pushed: Thanks! -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/