From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>,
Sergio Durigan Junior <sergiodj@redhat.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]
Date: Thu, 17 Oct 2013 20:52:00 -0000 [thread overview]
Message-ID: <87ob6ntyc4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52602A08.4020705@redhat.com> (Keith Seitz's message of "Thu, 17 Oct 2013 11:18:48 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> There are two little sections of code, though, which violate
Keith> const-ness of the input, and I've removed those, since they don't
Keith> seem necessary. [This is the two loops that deal with changing
Keith> the case of `tokstart' -- which can easily be removed because we
Keith> already have a temporary buffer that is used for this.]
I think it's somewhat wrong to do this stuff in the parser anyhow.
Ideally the symbol table ought to know that pascal is case-insensitive.
I think we faced this with Fortran as well.
Keith> [Perhaps Pierre knows? It was added here:
Definitely need a reply from Pierre...
Keith> - for (i = 0; i <= namelen; i++)
Keith> - {
Keith> - if ((tokstart[i] >= 'a' && tokstart[i] <= 'z'))
Keith> - tokstart[i] -= ('a'-'A');
Keith> - }
Not your problem, Keith, but there's other code in that file that ought
to be using the ctypes macros instead of this stuff.
Tom
next prev parent reply other threads:[~2013-10-17 20:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 18:57 [RFA 4/4] Constify parse_linesepc Keith Seitz
2013-10-01 4:15 ` Sergio Durigan Junior
2013-10-01 20:16 ` Tom Tromey
2013-10-02 4:38 ` Keith Seitz
2013-10-16 9:57 ` Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc] Jan Kratochvil
2013-10-16 22:07 ` Sergio Durigan Junior
2013-10-16 23:40 ` Sergio Durigan Junior
2013-10-17 18:18 ` Keith Seitz
2013-10-17 20:52 ` Tom Tromey [this message]
2013-10-18 17:20 ` Jan Kratochvil
2013-10-18 19:09 ` [pascal patch] Use case_sensitive_off [Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]] Jan Kratochvil
2013-10-18 19:34 ` Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc] Jan Kratochvil
2013-10-20 13:17 ` Pierre Muller
2013-10-20 13:27 ` Jan Kratochvil
2013-10-29 16:39 ` Tom Tromey
2013-10-31 16:14 ` Pierre Muller
2013-11-13 20:43 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob6ntyc4.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=keiths@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).