From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20470 invoked by alias); 17 Oct 2013 20:52:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20450 invoked by uid 89); 17 Oct 2013 20:51:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2013 20:51:58 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9HKpvKO028718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Oct 2013 16:51:57 -0400 Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9HKptkM016439 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 17 Oct 2013 16:51:56 -0400 From: Tom Tromey To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" , Sergio Durigan Junior , Jan Kratochvil Subject: Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc] References: <5249C987.50809@redhat.com> <87d2no4uim.fsf@fleche.redhat.com> <524BA344.2070802@redhat.com> <20131016095743.GA17072@host2.jankratochvil.net> <52602A08.4020705@redhat.com> Date: Thu, 17 Oct 2013 20:52:00 -0000 In-Reply-To: <52602A08.4020705@redhat.com> (Keith Seitz's message of "Thu, 17 Oct 2013 11:18:48 -0700") Message-ID: <87ob6ntyc4.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00540.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> There are two little sections of code, though, which violate Keith> const-ness of the input, and I've removed those, since they don't Keith> seem necessary. [This is the two loops that deal with changing Keith> the case of `tokstart' -- which can easily be removed because we Keith> already have a temporary buffer that is used for this.] I think it's somewhat wrong to do this stuff in the parser anyhow. Ideally the symbol table ought to know that pascal is case-insensitive. I think we faced this with Fortran as well. Keith> [Perhaps Pierre knows? It was added here: Definitely need a reply from Pierre... Keith> - for (i = 0; i <= namelen; i++) Keith> - { Keith> - if ((tokstart[i] >= 'a' && tokstart[i] <= 'z')) Keith> - tokstart[i] -= ('a'-'A'); Keith> - } Not your problem, Keith, but there's other code in that file that ought to be using the ctypes macros instead of this stuff. Tom