From: Tom Tromey <tom@tromey.com>
To: Hannes Domani <ssbssa@yahoo.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Use custom format argument in NoOpScalarPrinter
Date: Mon, 24 Jun 2024 09:49:16 -0600 [thread overview]
Message-ID: <87pls6tk77.fsf@tromey.com> (raw)
In-Reply-To: <20240619170754.1651-3-ssbssa@yahoo.de> (Hannes Domani's message of "Wed, 19 Jun 2024 19:07:53 +0200")
>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
Hannes> So values can be shown e.g. in hexadecimal notation.
This seems fine but see my note on patch #2.
Also:
Hannes> -def make_visualizer(value, raw=False):
Hannes> +def make_visualizer(value, raw=False, format=None):
Hannes> """Given a gdb.Value, wrap it in a pretty-printer.
... it'd be good to mention the new argument in the doc string.
Also I wonder if the other no-op printers might want a 'format'
argument.
Tom
next prev parent reply other threads:[~2024-06-24 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240619170754.1651-1-ssbssa.ref@yahoo.de>
2024-06-19 17:07 ` [PATCH 1/4] Handle anonymous fields and base classes in NoOpStructPrinter Hannes Domani
2024-06-19 17:07 ` [PATCH 2/4] Make it possible to disable pretty-printers in make_visualizer Hannes Domani
2024-06-24 15:48 ` Tom Tromey
2024-06-19 17:07 ` [PATCH 3/4] Use custom format argument in NoOpScalarPrinter Hannes Domani
2024-06-24 15:49 ` Tom Tromey [this message]
2024-06-19 17:07 ` [PATCH 4/4] Implement locals TUI window Hannes Domani
2024-06-24 15:45 ` [PATCH 1/4] Handle anonymous fields and base classes in NoOpStructPrinter Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pls6tk77.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).