From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: more filename styling
Date: Wed, 08 May 2024 17:50:49 +0100 [thread overview]
Message-ID: <87pltws0wm.fsf@redhat.com> (raw)
In-Reply-To: <87ttj846on.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> I spotted a few places in solib.c and build-id.c where we could apply
> Andrew> file name styling.
>
> Andrew> Other than the extra styling, there should be no user visible changes
> Andrew> after this commit.
>
> Ok. Thanks for doing this.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Andrew> "Do you need \"set solib-search-path\" "
> Andrew> "or \"set sysroot\"?"),
>
> Unrelated but I wonder if commands ought to be styled as well.
That might be nice. Do we have a style for commands? I couldn't see
one, but maybe we use one of the existing styles?
Anyway, I pushed this patch.
Thanks,
Andrew
next prev parent reply other threads:[~2024-05-08 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:00 Andrew Burgess
2024-05-08 16:19 ` Tom Tromey
2024-05-08 16:50 ` Andrew Burgess [this message]
2024-05-08 17:05 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pltws0wm.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).