From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 287323858D32 for ; Fri, 12 Jan 2024 11:05:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 287323858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 287323858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705057536; cv=none; b=YdO8uwwkqU593pg2WsJ6m9nknIDaYLwA2FBfcczr/kURWYWFd8Tuc9pDZ3uiTm+5u1mtiReyqfNGz7DwdfMMrleccsn1GR/D4M1+371mlUjlDpdpAGmF21lF7qWUAgk7qyKyrtKQKoYAIaVajoa6g0CZFiftgaw8UcdyG1mlAo8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705057536; c=relaxed/simple; bh=d6iqYT6HPXM+FQG1d1lSmjKjjLwI/RsPTvIDlJYjGkY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IttYSBaRFwnAMebG47Xj0ghRcHbVXno1tRZkxFcc3wA8wZSBjWxhgobtheeexSmrSU4qhOBxHNRA8ezu147lPaOjvjYKoeaq/PYFptO8NtK9EMPlPqAnfkUVzJSJcpDf0TE3aNq+MzA2e2HZKdQYrJVemoneiB5HK4GVcbHp3oE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705057534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fs+7G/XxQc0iU2xFP21vO5l9fpvtHYdjXi8CgsRhSM0=; b=XRXXAkjEk14pLMYKUj8/0qJcaevYI2KH0Z/Su2GM0xw+cEOc9Udn4BUkxK+SvdvRtFEL06 4Jz/jrHPxgtf4SLQ6p5rQzsxkY9lyJKyfAYCL6Hj+T64RBS9xWL2NhqfBIq9TYnnrZsvnT WE/ltGE6w0WpW4PUE87tjNpPwUuF4K8= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-mi_IeWUQPK2JKlJx7j9vGA-1; Fri, 12 Jan 2024 06:05:33 -0500 X-MC-Unique: mi_IeWUQPK2JKlJx7j9vGA-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a2c12d0c5a7so74020466b.2 for ; Fri, 12 Jan 2024 03:05:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705057532; x=1705662332; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fs+7G/XxQc0iU2xFP21vO5l9fpvtHYdjXi8CgsRhSM0=; b=ErumuHMp008vx8YkYgqG68lK8Q8XsPgsYzBao27lxogNDsMNvA1F72DVKX3TtcJYgQ y3uiPrFy98LqXdwS0kEu/RMtQDVPVYssUHGITUAX4ULAixcAOcu1XWOiY/jKRjY3ndFn oNzEGjTsKIF00V4mJFvYDvOEi/PnSDSPCb8qFr1ATWPDJDF1E/jPJd80yHQR1M9P2IMG T2p5UxqffI+tQvg7TBTys5WqmXWgADMHixeTbh8e6MEYKv728YdIkb5jteVHOnFY3/9N s9pVMWdZkZRxI3ouM6+aZsmrZvJBfakk0BgUjUIGFpGAmOn4hFJhCT5Ky5jXiOckXVCQ dq1A== X-Gm-Message-State: AOJu0YyTDafvSTDEiGlXVlYwigkq9GkkLbIhA/JxniTE3326eunVb1GF H5o/WOWTSIE9hy3JL49OsUaSa6QXL+uSY2W+DkWwuP8ySinebJXk+ByHa9aqr/1ui0hsUC0Kopl jdcSZQ5tdafAqzwX6caTtryBMNLl+UQ== X-Received: by 2002:a17:907:2da1:b0:a28:5901:70dd with SMTP id gt33-20020a1709072da100b00a28590170ddmr787783ejc.17.1705057532518; Fri, 12 Jan 2024 03:05:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwcyKQL/9IlNSjKuxlJJFLSB8nwescXh3xyBc0qFLwODK4yC3muJd0Bajqu4iCd2Fmj0d3wg== X-Received: by 2002:a17:907:2da1:b0:a28:5901:70dd with SMTP id gt33-20020a1709072da100b00a28590170ddmr787776ejc.17.1705057532242; Fri, 12 Jan 2024 03:05:32 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id v15-20020a170906180f00b00a28cf49520asm1656289eje.203.2024.01.12.03.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 03:05:32 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org, Tom Tromey , Lancelot SIX Subject: Re: [PATCHv3] gdb: add trailing '/' when using 'complete' with directory names In-Reply-To: <87ply7rdpf.fsf@tromey.com> References: <87ply7rdpf.fsf@tromey.com> Date: Fri, 12 Jan 2024 11:05:31 +0000 Message-ID: <87ply67qx0.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> In V3: > Andrew> - Add link to bug Tom pointed out, > Andrew> - Use concat rather than temporary std::string. Save a strdup call, > Andrew> - Added 'explicit' to the constructor, > Andrew> - Remove weird 'const reference' thing. > > Looks good to me. Thank you for doing this. > Approved-By: Tom Tromey Pushed. Thanks, Andrew