From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 223453858005 for ; Thu, 11 Jan 2024 17:18:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 223453858005 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 223453858005 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704993506; cv=none; b=AX8ZgqBwAsLzNlv831/6RjdLLyUYWaIRiUs8ljt+G7Q1NcW+mEDvbUJxaP22btuEQZfHIdoISqaeqdXTyO6KVOaxiq0H+b+j+If+Q1hMUAsaqFnxF5tO0N+oW9JmAh5Aq+mT3YQOlqBajDzRm/u+/WV05B8Jis5xdk5tT6DXV6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704993506; c=relaxed/simple; bh=byVsWjucFSmI7PGFQddHBp8LqA2j0PMvMctNN31nnFI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=mGnGllWm00p1YW27mTzWcDJlFanNQArHNWXjhNCyLUxol8krScua2aHzg+MxXfkaVojXW428qIr7oWIX3MrCC0ggOJAzKYbr6E3/JMBWLSj591aYrJhfDOfH2slSPp7AuZCMAE2bh0ZnoJdMZA+IHNWENaKc3ClZCNv8gdp7jP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id NuhBrZvwoCF6GNyhDroxQY; Thu, 11 Jan 2024 17:18:23 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NyhCrkbbnjqQkNyhCrzr1J; Thu, 11 Jan 2024 17:18:23 +0000 X-Authority-Analysis: v=2.4 cv=A7F/goaG c=1 sm=1 tr=0 ts=65a022df a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=OGiI4Vcqrb9aqGUlhUQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uNq5NwR+qeLxm0CYK/rNvbnSvex+Y+w3qMogWJqCaww=; b=kYidM2FHeMfYavejnuF2xXwRbh eXn0Gqmt9/EBFtWtY6DcXMVm9RJWl/4V/xOvPqXKlgSQu5vgnAHhtH8RgeARihGyqWG8Ijan4R02i bwtuVwx8vQP70RPDjqfHFUm8W; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:39282 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rNyhC-0043K6-0a; Thu, 11 Jan 2024 10:18:22 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey , Lancelot SIX Subject: Re: [PATCHv3] gdb: add trailing '/' when using 'complete' with directory names References: X-Attribution: Tom Date: Thu, 11 Jan 2024 10:18:20 -0700 In-Reply-To: (Andrew Burgess's message of "Thu, 11 Jan 2024 16:02:32 +0000") Message-ID: <87ply7rdpf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rNyhC-0043K6-0a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:39282 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHJhChYo75h7naMmirqYYDt16dsdvTs6yfo3nUtQjOny/czZKVJgxGbbHZbIO/nTuCkBQ1kk/SqScwEsya8hhF8RdfBSXD9cyO3K8grxx44oeIXLpAVz YeHijPO+Zi3njL0vC4sMk6L+9Mz+6lZv0ZIEbUptBNhFjPwIwjKUzXL3f+BEj2D4pMiPU9ss9kXmAPMbJv8+n5AjWyiE5d5tE3s= X-Spam-Status: No, score=-3016.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> In V3: Andrew> - Add link to bug Tom pointed out, Andrew> - Use concat rather than temporary std::string. Save a strdup call, Andrew> - Added 'explicit' to the constructor, Andrew> - Remove weird 'const reference' thing. Looks good to me. Thank you for doing this. Approved-By: Tom Tromey Tom