From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 68DE73858C2F for ; Tue, 12 Dec 2023 18:34:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68DE73858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68DE73858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702406054; cv=none; b=jOW3DUUcwEGXDdqlmQIaCuPWzkzaJuJ3gMM6Dbb1hQciQpQtszAzZZY5Bv1t/0OdNVhC/4g7glMF2rEz1cA1odocgJSn+V4kJneoL5BUb7epMyV+YJkNAaNwiYayQjFEJ171YO+u1wXKfW8MEptTet/RWiSt+GHCKRnhMn8DvVg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702406054; c=relaxed/simple; bh=16LFOTf4Wu3SizLi5nsv6Cb+ZidVArZ/fgk4WTLyKxs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=arhlcdPt0A8IJhY5yfP+1OXQP2YKpD2LNVCvbGWsZNr6T+axlXDzajMIj6pSZ8vp+3Lj+keMowtWBDXUuV4Qk9lmdQlRtI+WfJ4zJKMtyh6vZC+jXV6HGiqTfyQrkUHfwv1f0DlTKbybR0n8CJsMJvzw2TU0me9ewHCGqJEN+Z4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id D7WFrEh9i8HteD7a7rSF9G; Tue, 12 Dec 2023 18:34:11 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id D7a6rdXO4qmEoD7a7rFTiv; Tue, 12 Dec 2023 18:34:11 +0000 X-Authority-Analysis: v=2.4 cv=P+8pOwMu c=1 sm=1 tr=0 ts=6578a7a3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=Fc6mgWHyf0LYIRRqefEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GGepAB7fo7c23/3/6UFxbwd2UeefKAaHvh4ukT3zlhw=; b=W9330Vf8escdC7p5IDtL9p1np3 8rGWE8fqlllsrXbh5NJ6kpy/NrtxWNsCA2rEzgdV0tcymRR2pqjYnMCmMEzLQaQhA4hEIkkIs3aeb OhjgkQGFNet/GFA3QdFQgwi/r; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:46454 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rD7a6-001KSp-1q; Tue, 12 Dec 2023 11:34:10 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 03/13] [gdb/symtab] Handle nullptr parent in parent_map::set_parent References: <20231212173239.16793-1-tdevries@suse.de> <20231212173239.16793-4-tdevries@suse.de> X-Attribution: Tom Date: Tue, 12 Dec 2023 11:34:09 -0700 In-Reply-To: <20231212173239.16793-4-tdevries@suse.de> (Tom de Vries's message of "Tue, 12 Dec 2023 18:32:29 +0100") Message-ID: <87plzbclsu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rD7a6-001KSp-1q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:46454 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDz/l6mRpOmgOq7jXj/Pn2EHumJ1LjAwrlrpfOTHY8fmhAJbg8kudx+Jc38LKz9F6r/yKKT957vj13pS+CNLTw9RU0nXsxwTTKeR9QkgO2STnK6OCu0b i4CuyLKYcWktu+pTKVEEHIyaha/7Rk5SepFf1lC/CuBBw2kph7oMw7aNoMlpUl5W4AuM4QrboS/Knggs7qFRPNjh5gE3ZI43VDg= X-Spam-Status: No, score=-3017.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Set_parent uses m_die_range_map.set_empty, which doesn't allow Tom> parent_entry == nullptr. Tom> So it may be necessary to guard calls to set_parent with Tom> "if (parent_entry != nullptr)". Tom> Fix this by handling the parent_entry == nullptr case in set_parent. It seems like this must be a programming error somewhere? Currently the only caller is guarded: if (parent_entry != nullptr) ... m_die_range_map.set_empty (start, end, (void *) parent_entry); Tom