From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 8D0723858D35 for ; Fri, 20 Oct 2023 20:11:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D0723858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D0723858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697832679; cv=none; b=ABD2g5EvoDUfbnH0TwMH8APGHPIbDk4Z3mE6XEgfJwab3KxwyK7pxWXU3k+d0AzqJcAwZjn+8hOSdvy2CCUe9EIOj36qFG3JQ2rks/jthVKuWVJrtHhlrb2PpllEOs8E48TPAIGeRPUTDNYyvdPKBqj0y/Uk1ThoJH1UUccPIBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697832679; c=relaxed/simple; bh=vu4W1sKhdoe3pSl9rm8EecYPeU8nu7xq1klAFrSC7HQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZgGxxe3LgrI6QYWYl4Ff0mrffPfdV/8+1lgTyRMJMN7YFV/NFGZ4P26jSmCxOrHiPJvQNtBObdcxYyJGomOOwswuzvkFbIbZBbl2a1aSL/eJGp24SBxVq4UlCCRq9b5Q2yQbE7rtO/WlIGZ/p06dbF5agKZT4+S14hB3wJ4MiwE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id ttWgqHuD8L9Agtvq0qWdZu; Fri, 20 Oct 2023 20:11:16 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id tvpzq2UuHNUwRtvpzqf9kg; Fri, 20 Oct 2023 20:11:15 +0000 X-Authority-Analysis: v=2.4 cv=I852+fsg c=1 sm=1 tr=0 ts=6532dee3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=bPpL4evqcW-LvbYVNYsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bQTMor0lXduceWUieO4ebkbTj/XIj9W6DaYSIZ2e3sY=; b=nakkNeqAlt6hVAtLeQMgCQyVjf ygHrrw3MlMUR+/I4/TFvvTuXgQJTRGHx+4Ti6bormKMrmLN4VmuPwsoSp8piDo6+AqMi2JKpc5/Fg 6qt/zlgba7QOR8hd40ldOw5Tp; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:42624 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qtvpy-002w82-37; Fri, 20 Oct 2023 14:11:15 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 07/13] [gdb/symtab] Resolve deferred entries, inter-shard case References: <20231002125051.29911-1-tdevries@suse.de> <20231002125051.29911-8-tdevries@suse.de> X-Attribution: Tom Date: Fri, 20 Oct 2023 14:11:13 -0600 In-Reply-To: <20231002125051.29911-8-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 2 Oct 2023 14:50:45 +0200") Message-ID: <87pm19njfi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qtvpy-002w82-37 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:42624 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNZTVsbDZLi3L7/G9tDAfCBafRi6ot8fbHaZuxMP0OeFSEtH6Q+sfBdSM0ISjsWTYUfhjr3WjERAf6d+oiS0WqByrNmurbn6XNUzR8GYbKag2WE7SfsX tFEXjulvQCfQBCeRuMnnEU54OyfQZKQOSX6UJvt6+Z4+/t+tk5aGxfV4WWR/7BK98yUEU/oPvKvcttJHZ8vZLreoNLn5PZrxoi0= X-Spam-Status: No, score=-3018.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> We need to generically solve the case of inter-CU dependencies, and that Tom> includes inter-shard dependencies as well. I'm not sure we really do. AFAIK compilers don't emit this, only dwz. So maybe there's a way to make it so we only pay the cost for the dwz case. I may send more comments on this patch later. I find it a bit hard to review, mainly because this part of DWARF is my absolute pet peeve. It's so needlessly bad. Tom> @@ -446,6 +452,8 @@ cooked_index_shard::wait (bool allow_quit) const Tom> cooked_index::cooked_index (vec_type &&vec) Tom> : m_vector (std::move (vec)) Tom> { Tom> + handle_deferred_entries (); Tom> + This is done in the main thread. How much does it slow down startup? Tom> + for (auto &shard : m_vector) Tom> + { Tom> + delete shard->m_die_range_map; Tom> + shard->m_die_range_map = nullptr; Tom> + delete shard->m_deferred_entries; Tom> + shard->m_deferred_entries = nullptr; Tom> + } I think we prefer unique_ptr rather than explicit deletes. Tom