From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 9B3CE3858CDB for ; Wed, 4 Oct 2023 22:50:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B3CE3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1c87e55a6baso2149815ad.3 for ; Wed, 04 Oct 2023 15:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696459843; x=1697064643; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=J7o4qvyEP2E961ESR8Fs+6aBYBxmpnLMbjhggZpbcpM=; b=GE1hctt2coxfQMWNOx93D6t0B5z+EeTsSFFwmHXHjlWuztpNonfMnguchB4qHY5tpR KcAmioNGZ3hKBvNf7o/ypvY5/YKLyECPPPgAy7WyC/XaLUCILte95rQhAQ56m2zGBdZQ H7Edhw+ntfYn03S/1vCGWoi3y+XTUiQv2SHkvTm7my98QUQycCOgsrFSGkio8+KkG/lc iO4Mvb9yGElSopmzDEFd6NOwZpUF5EcmeePMkdEE/zbVOJfgtGSyybFqbPNrHrE8OHk5 YgUQwE+D8LBW6AqODr3j3lQpieXKVUUu43gXAfu2w191sT4SL35lR/JYhpp92EFfPmJy 3xAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696459843; x=1697064643; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J7o4qvyEP2E961ESR8Fs+6aBYBxmpnLMbjhggZpbcpM=; b=uftJtLuGHwFbfhnF20PwfmSL2JY4C5PKscz2+Lb6oHMXKzgVV4sx2lixoiVXuAwvpB 0Bu9HIAYsL0/yuDVm3HoFzeUYUisislnQTgsVGztD5wgodnNUBaTj6NO7+vgKDuuyYO4 QzKWNB5UTL6qLFdZ92PTVLUUWo6/9P+A0Wi0R+ppYIVKDqad2q8fLmiUaAB1OmJDBxE0 MQGzUi2ZEi6/AdVewyqJ3ULadIPOhFLvjnPG7e7sywpcMaTCRKASG1+moqDJM1QqLIHe iY+upHbXO/u09LNxwlEzSk7GtBzo6mS61j0W6vir0qWgWaNej/2V9hNHWBUgDufbg1m4 Aykg== X-Gm-Message-State: AOJu0YwmB8XZ7AuRdPUX8DSxmxWl6yaAFls/rORyurvXPv9TPplquqyN Rm6iaOghelp8vLM6oT0V9RaWyA== X-Google-Smtp-Source: AGHT+IE8IZsTzOFwppaQeY0n8rGlHQFdU3/jFsahAaapQkCR4kwOAqcC5w/6xMQ/ht2B63KIJoqMrg== X-Received: by 2002:a17:902:eb44:b0:1c3:ed30:cdf4 with SMTP id i4-20020a170902eb4400b001c3ed30cdf4mr3668368pli.4.1696459843551; Wed, 04 Oct 2023 15:50:43 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:2dfa:6486:a698:5ba9]) by smtp.gmail.com with ESMTPSA id n3-20020a170902e54300b001c20c608373sm79831plf.296.2023.10.04.15.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 15:50:42 -0700 (PDT) References: <20230929175313.24845-1-thiago.bauermann@linaro.org> <82422697-8aa9-d56a-8aa0-2c60703d5276@redhat.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Thiago Jung Bauermann To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] process-dies-while-detaching.exp: Exit early if GDB misses sync breakpoint In-reply-to: <82422697-8aa9-d56a-8aa0-2c60703d5276@redhat.com> Date: Wed, 04 Oct 2023 19:50:40 -0300 Message-ID: <87pm1um27z.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Guinevere Larsen writes: > On 29/09/2023 19:53, Thiago Jung Bauermann via Gdb-patches wrote: >> I'm seeing a lot of variability in the failures of >> gdb.threads/process-dies-while-detaching.exp on aarch64-linux. On this >> platform, a problem yet to be investigated causes GDB to miss the _exit >> breakpoint. What happens next is random because after missing that >> breakpoint, GDB is out of sync with the inferior. This causes the tests >> following that point in the testcase to fail in a random way. >> >> In this scenario it's better to exit the testcase early to avoid random >> results in the testsuite. > Thanks for working on this test, it has been driving me up the wall for a while! Yes, this caused a few false positives in our CI. :-/ >> We are relying on gdb_continue_to_breakpoint to return the result of >> gdb_test_multiple. This is already the case because in Tcl the return >> value of a function is the return value of the last command it runs. But >> change gdb_continue_to_breakpoint to explicitly return this value, to make >> it clear this is the intended behaviour. > I like this change, since I didn't actually know that this was TCL's behavior! Tcl works in mysterious ways. :-) >> Tested on aarch64-linux. > > I tested on x86_64 and I see no regressions. > > Tested-By: Guinevere Larsen Thank you for testing! > I hope this gets approved soon! Me too. :-) -- Thiago