From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id AC9CF3857354 for ; Tue, 29 Aug 2023 15:35:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC9CF3857354 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-77a62a84855so159173339f.1 for ; Tue, 29 Aug 2023 08:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693323314; x=1693928114; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1VaBVdH6nQ5TByPauHTQRYoZPz7mbA4ltguI62L+po0=; b=HRKUQDAvXv1rQ1ehpJZSU1Aq0Z6qRgF5XJedBZ9fVuLhmpoAmBx+YXygYc2xi8yp2I aJVuiIJkS6tG8ieepcOA4YhroymVCWm75rRaF8y978L3qszp2foWu/eBiokrxplqPrd6 Oo+AikGuEcvM227GRbQbrnmMmN8yKwLC/QIqMkzvrZ5kFmEMYowhJOWKRPOtoShCycsl KjlBQTWW4k6Jxr3k6vu9F0RNNIUtoFN+MGybKM+e4viQPcF8CV6m3FQ9SJ4PNaa7PqZQ s+kWnJRLQND86T0nwL8XNu7QgnZTYC1ZU8TJBVKKHUMTpCOdK9nfJzd5sAvF9gPmkmGo D38A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693323314; x=1693928114; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1VaBVdH6nQ5TByPauHTQRYoZPz7mbA4ltguI62L+po0=; b=Q9pu+jfk+Kw/GaEkcrNqMaGMW77giDCWhg62/SvLPxYIk9JNGOjyalzXT8+PytGSEG PW64Hdfaoo5Fz9TPmKdLNJlAuYRsgreD1MXU1+qoNAO3Jm7C/WqL/Ne/MDYLxqauykGr qo9kpC+atAqyEs/O7N1Pc3bNx0kE0CW9g2yXGeU1SGaVeFXe113tCbrWsMoDDQIYLwup jDUhiRHl7WzfQzOHBFL8V1HPNy8JUoN0x49hB0JnyFrtcTJ2AuZUhRlxZ3kiNQ7/RrqE 17YNor54w4IsN2aYrO1HnHvUPhsCr2vqfv7PCD2QBkNfx/ASWUTOnVYnbsR9T5Gnb4eR dNsg== X-Gm-Message-State: AOJu0Yzw0g9Pbt2IoRV4elyeWY+qLfjDxEIaIqplSE7Dn5m4Y7a9Q5Q6 VTxCL5gkqDG9bnNYNtUaTFwi6lc/awcnm5nbAIlnoA== X-Google-Smtp-Source: AGHT+IF0Kz/cLwGg6d3tKvMo4lFAST5JY4KDR2MUe94ca33nUEY4QOgkGy3C/xIvwFwIsdbSgpjg6g== X-Received: by 2002:a5d:89cd:0:b0:792:72b8:b90 with SMTP id a13-20020a5d89cd000000b0079272b80b90mr14780248iot.16.1693323314028; Tue, 29 Aug 2023 08:35:14 -0700 (PDT) Received: from murgatroyd (75-166-150-212.hlrn.qwest.net. [75.166.150.212]) by smtp.gmail.com with ESMTPSA id ge18-20020a056638681200b0042b482a8763sm3117214jab.70.2023.08.29.08.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 08:35:13 -0700 (PDT) From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/5] Small cleanups in array_operation::evaluate References: <20230828-cleanup-array-op-v1-0-12ca00f20917@adacore.com> X-Attribution: Tom Date: Tue, 29 Aug 2023 09:35:12 -0600 In-Reply-To: (John Baldwin's message of "Mon, 28 Aug 2023 14:12:03 -0700") Message-ID: <87pm35svyn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "John" == John Baldwin writes: John> It might be nice as a further cleanup to rename tem2 and tem3. Based on John> the arguments passed to value_array, the ideal names for those would be John> something like 'lowbound' and 'highbound' but that clashes with the John> 'low_bound' and 'high_bound' used for the nested array. :( I added a patch to do this. Tom