From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 21DA838654AD for ; Fri, 18 Aug 2023 19:02:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21DA838654AD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-79210064604so18401139f.3 for ; Fri, 18 Aug 2023 12:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1692385376; x=1692990176; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9nL7Ys2XF8z5GCXUb8gdoNoHPm159g2w4TCaCArgDTA=; b=Js8lcyyB2ZjM9g1FOYr12pRO/lkb8Y1jWg7yQyWeOkVP7ZSyYJ+4wF1Gg0nIRSUxCh 89OSVslEMMq6fBqIJt+IY8qW7gniPXQZRkzntSULO5YuDioLlAOhE0Mfk3X02CQwQ4lk kHxx+g67rAcewRHkTEEY047fL722MpLvozH9OzeXTdIGEicsMON+akGP5R7RRjYpvBW0 ko4ZGxZfTpNt9BvGdfVOPKxjhr7u3X2YTWaAt0mXzAXvV9oMW1Z2Ae2NBUAfRcNOr/PL 7ZpxWV9gpyMlhEmfGOEz3xzlEQCq47KmqqcvCRCqsoPf902aYphLBNJEAcXtwvvlBY78 OynQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692385376; x=1692990176; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9nL7Ys2XF8z5GCXUb8gdoNoHPm159g2w4TCaCArgDTA=; b=eXRwR0wM8pFWkWzFvcRKd4++sWtW2N+sktl3oiAmvqbCLGuTBBeTN5slZgSnMqvmo5 fCodmC7PnkCbLqCfuE/OmijsCr+VkBGkdI16Gb94dcwgbfFd6BYbRkCBVA/aH+XJdSZO 0cjZzw/Z51pJGqKrjVz7xxeI0y4gCnSbq3Ubq5YHqt5T93b5lEANpZAqmOBXqtUvnL0k KQBgTClTZkQs/KvHCrOb6QMQlrjyLksRHhZDwz/5YbkaBK62CENhNpPpL+fkr66h413W sbvvUx0QA/ZlTH1DMxrrFf/f+nQCaXdnJJTKpuAyLl8qKzJTSUFFFxRXs9qsOspN5HJC R7Gw== X-Gm-Message-State: AOJu0Yxl26gz8cVB35Qs8MBgUQrjfIJEvrz4Qu/ONeVmzac50r0l/3Um Lqp8GEBHZzPE5ZAZxCZsSDEA1A== X-Google-Smtp-Source: AGHT+IGK/SmsJo5VaNgwlTbvEQ9pK1QFqIbpq6kvppAT1I7eefyfUni6p42hOGlAYRVsGdiXtIqHRA== X-Received: by 2002:a5e:980c:0:b0:790:6629:b222 with SMTP id s12-20020a5e980c000000b007906629b222mr184580ioj.5.1692385376352; Fri, 18 Aug 2023 12:02:56 -0700 (PDT) Received: from murgatroyd (75-166-142-177.hlrn.qwest.net. [75.166.142.177]) by smtp.gmail.com with ESMTPSA id b20-20020a02c994000000b0042b08954dc3sm682373jap.33.2023.08.18.12.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 12:02:55 -0700 (PDT) From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix off-by-one in call to vector::reserve References: <20230818140346.1255946-1-tromey@adacore.com> <3c557b21-d49b-cbc8-de49-237a52f8a2fb@FreeBSD.org> X-Attribution: Tom Date: Fri, 18 Aug 2023 13:02:54 -0600 In-Reply-To: <3c557b21-d49b-cbc8-de49-237a52f8a2fb@FreeBSD.org> (John Baldwin's message of "Fri, 18 Aug 2023 09:15:06 -0700") Message-ID: <87pm3kw4v5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: John> Pedantically speaking I would probably write it as '1 + args.size()' as the John> extra pointer is pushed first followed by a copy of all the items in args John> (that is, trying to make the expression list the sub-sizes in the same order John> they are added to the vector). Sounds good, I'll do it. Tom