From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 65C0D3858C5F for ; Fri, 4 Aug 2023 17:17:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65C0D3858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id BD1D710047D71 for ; Fri, 4 Aug 2023 17:17:03 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RyQBqbIK16i54RyQBq9Aq0; Fri, 04 Aug 2023 17:17:03 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QsWbYX+d c=1 sm=1 tr=0 ts=64cd328f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=JmGJ3QXUtKjqezP4VTcA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IKcZcnDKaNQfMCVzPXuSRoAGtEwj1BV1lQS74PmicdY=; b=nfZ71gxOo2gH0cKxx/JKksHBb3 8RWxOZrDEgYRwUkV7l0BQHwb4W9tE1J3QU72o6Hb5WfvOQeqIiC4fxo+DFmb1rmoFGZ/W25sDIIQV j76lR3pO0lVURgj1zta+FFuKz; Received: from 71-211-152-221.hlrn.qwest.net ([71.211.152.221]:47342 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qRyQB-002Xik-1a; Fri, 04 Aug 2023 11:17:03 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [PATCH] [gdb/symtab] Find main language without symtab expansion References: <20230804112243.11537-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 04 Aug 2023 11:17:02 -0600 In-Reply-To: <20230804112243.11537-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 4 Aug 2023 13:22:43 +0200") Message-ID: <87pm42afsh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.152.221 X-Source-L: No X-Exim-ID: 1qRyQB-002Xik-1a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-152-221.hlrn.qwest.net (murgatroyd) [71.211.152.221]:47342 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Reimplement the feature by adding Tom> cooked_index_functions::lookup_global_symbol_language. Thanks for the patch. Tom> + /* Expansion of large CUs can be slow. By returning the language of main Tom> + here for C and C++, we avoid CU expansion during set_initial_language. Tom> + But by doing a symbol lookup in the cooked index, we are forced to wait Tom> + for finalization to complete. See PR symtab/30174 for ideas how to Tom> + bypass that as well. */ Tom> + cooked_index *table = per_bfd->index_table->index_for_writing (); I think it's more normal to use: cooked_index *table = (gdb::checked_static_cast (per_bfd->index_table.get ())); in the body of cooked_index_functions. Tom> + for (const cooked_index_entry *entry : table->find (name, false)) I think this is probably racy, if the intent is not to wait for finalization, because cooked_index_shard::find uses the canonical name. Maybe we need to resurrect the approach of looking for "main" in C/C++ CUs. I don't really remember all the state of this right now, there's been a lot of flux. I did also reimplement some of this on my background DWARF reading branch, but I think that's kind of invasive. Tom