From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 90BFC3858C50 for ; Fri, 28 Jul 2023 18:22:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90BFC3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-348c03de0e7so9436455ab.1 for ; Fri, 28 Jul 2023 11:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1690568542; x=1691173342; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7SYTWV3xXGAe/J0RcGMNRCH/ZBcF7eEDk1/a2aor8RA=; b=fMMEF1Fp7Q+38oyeWKt9AYFhSUbNsi6b+NnwGQMEVEww/VCnX+GewLu6bzF+9k3UJv 1oBbr5OHI2aGzVCxebrDEcSZiw84vCnxSbtXjI8Qy6Y7wJySPTOIVTQK0jl8IbrggAxv ofeFU32HbBW137PO6krUcSlNf8FlbjV2Jjh1q5xW08YejwLPGqDJQeSky98XF4gWFRZf kHzRCmr6cGty7w9xc4+KF4v9NCBzyWSQyUDihb4MhYWBHv5RqcWiHvdGVqnJ17vpeIL9 jwIo3Rw3HmEm/KMY4jNsplUxRrh1WYLEqz+t36/t7pvhLJbVj0hnlTMNk4zt1intJ7Xj Q+ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690568542; x=1691173342; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7SYTWV3xXGAe/J0RcGMNRCH/ZBcF7eEDk1/a2aor8RA=; b=HrsRnjshn6lbYweae+10OTkZtp9bFbAYNzj30jsyFZZ++I8Oc7DzM2fi8RO9fEquhL 0G4wak9RFT1BKuA5hdkf4+iR2wRtwzlFhpaIe+6la7UsfGeMAtnwae3jZhX42oyNqt5f LxfksZTCOP1hn3pUmUTTXhOGS5lNb/DdWgFELM0IBKQaf0RyF8sjfus23biAZ19JUw8e FTescG8cRNzcdfz/WmOLKzvJGU0DcjBiJynw7MN9fPNFuWFVeHWCaBW4nrw3zTvH1wMr ytVKN6Rpf1r91edufVPgKEpJS+bfM9DDcxWX+fOlEWZv0Ti65eCbxPycjCa2GGb8x8yH d/6Q== X-Gm-Message-State: ABy/qLb9eEBJEGAsLUKCWJMFcieDGjD0+tunk+fC1/1lti+qInWXIUs8 L02zCNe4pDptzDYtY7Ycq4JMVw== X-Google-Smtp-Source: APBJJlFcVE8CizMoGSHVEAr0tvGvR+Q1+0p6rTRuarqtSjWGQmsiFRiP7vFAOyPRfTlbAe6zqrB7wg== X-Received: by 2002:a05:6e02:c72:b0:348:caee:6fc8 with SMTP id f18-20020a056e020c7200b00348caee6fc8mr350830ilj.15.1690568542456; Fri, 28 Jul 2023 11:22:22 -0700 (PDT) Received: from murgatroyd (75-166-135-140.hlrn.qwest.net. [75.166.135.140]) by smtp.gmail.com with ESMTPSA id o14-20020a056e02068e00b0032afe23820bsm1327691ils.17.2023.07.28.11.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 11:22:22 -0700 (PDT) From: Tom Tromey To: Simon Farre via Gdb-patches Cc: Simon Farre , tromey@adacore.com Subject: Re: [PATCH v5] gdb/DAP Fix disassemble bug References: <20230712184519.182460-1-simon.farre.cx@gmail.com> X-Attribution: Tom Date: Fri, 28 Jul 2023 12:22:21 -0600 In-Reply-To: <20230712184519.182460-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Wed, 12 Jul 2023 20:45:19 +0200") Message-ID: <87pm4bhp5u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Farre via Gdb-patches writes: Thanks again for working on this. I'm sorry it took so long for me to get back to it. Simon> +# Disassemble "backwards" Simon> +def _disasm_backwards( This should be marked @in_gdb_thread. Simon> + # We take an arbitrary jump backwards Simon> + # Guessing that an instruction averages at 8 bytes Simon> + start = end_pc - 4 * offset I don't understand the relation between the comment and the code here... I thought it was just a typo but later 8 is used, so I don't know. Simon> + tmp = [] Simon> + # fill remaining ins with "invalid values" as per DAP spec Simon> + for i in range(0, offset - len(instructions)): Simon> + tmp.append({"addr": 0, "asm": "unknown"}) I guess this could be: tmp = [{"addr": 0, "asm": "unknown"}] * (offset - len(instructions)) Tom