From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id B75F43858D39 for ; Thu, 27 Jul 2023 16:12:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B75F43858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id E8956100421A3 for ; Thu, 27 Jul 2023 16:12:54 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id P3biq24kONWjFP3biqUOKy; Thu, 27 Jul 2023 16:12:54 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=duget3s4 c=1 sm=1 tr=0 ts=64c29786 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=bMJAhgpp0gYlXJvrfT0A:9 a=zZCYzV9kfG8A:10:nop_mobile_phish_fin_urg a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RVR7zmw9om1lKx2jkC3oZj9MYru13DhZOs4U6xy7Tfo=; b=Zdea6yw3fsub6pjJOE+DBSOvv2 70HJDqUSLNpQKv5xkuKK5In/gKvLEooQnhCG4Huab1GflAdjYToeDWYjVItqApu0tqreIpbYeGVjb tzKFbMhZcqK4kzEuXjm4k64pR; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:33986 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qP3bi-001DkQ-1t; Thu, 27 Jul 2023 10:12:54 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: remove trailing empty line in target-delegates.c References: <20230726191136.36864-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 27 Jul 2023 10:12:53 -0600 In-Reply-To: <20230726191136.36864-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Wed, 26 Jul 2023 15:11:26 -0400") Message-ID: <87pm4dib96.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qP3bi-001DkQ-1t X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:33986 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> In a review [1], I pointed out that applying the patch, git would say: Simon> .git/rebase-apply/patch:147: new blank line at EOF. Simon> However, since the empty line is in target-delegates.c (a generated Simon> file), there's nothing the author can do about it. To avoid this Simon> comment coming up again in the future, change make-target-delegates.py Simon> to avoid the trailing empty line. Do this by making it output empty Simon> lines before each entity, not after. Simon> Since this needs removing a newline output in gdbcopyright, adjust Simon> ada-unicode.py and gdbarch.py to avoid changes in the files they Simon> generate. Seems totally fine to me, thank you. Approved-By: Tom Tromey Tom