From: Andrew Burgess <aburgess@redhat.com>
To: Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org>,
gdb-patches@sourceware.org
Cc: ahajkova@redhat.com, Christina Schimpe <christina.schimpe@intel.com>
Subject: Re: [PATCH v2 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command
Date: Mon, 27 Mar 2023 14:31:24 +0100 [thread overview]
Message-ID: <87pm8ub9sj.fsf@redhat.com> (raw)
In-Reply-To: <20230327095425.601412-2-christina.schimpe@intel.com>
Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> writes:
> From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
>
> The ERROR_NO_INFERIOR macro is already called at the beginning of the
> function continue_command. Since target/inferior are not switched in-between,
> the second call to it is redundant.
>
> Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
Approved-By: Andrew Burgess <aburgess@redhat.com>
Thanks,
Andrew
> ---
> gdb/infcmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gdb/infcmd.c b/gdb/infcmd.c
> index e2032d18564..a68611538f2 100644
> --- a/gdb/infcmd.c
> +++ b/gdb/infcmd.c
> @@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty)
> }
> }
>
> - ERROR_NO_INFERIOR;
> ensure_not_tfind_mode ();
>
> if (!non_stop || !all_threads_p)
> --
> 2.25.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2023-03-27 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:54 [PATCH v2 0/1] Remove " Christina Schimpe
2023-03-27 9:54 ` [PATCH v2 1/1] gdb, infcmd: remove " Christina Schimpe
2023-03-27 11:41 ` Alexandra Petlanova Hajkova
2023-03-27 13:31 ` Andrew Burgess [this message]
2023-03-29 11:01 ` Schimpe, Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm8ub9sj.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=ahajkova@redhat.com \
--cc=christina.schimpe@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).