From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 699C7384D18E for ; Fri, 24 Mar 2023 16:16:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 699C7384D18E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id C89BB10047D95 for ; Fri, 24 Mar 2023 16:16:46 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id fk5upMkfaBdWBfk5upLDBK; Fri, 24 Mar 2023 16:16:46 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Yfh4Wydf c=1 sm=1 tr=0 ts=641dccee a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=0OBsxWdCTd8F06l0yloA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qs1FszbwwqGL8sNufe5GyUHA+As52me1CrpfSzgwSDU=; b=tR3OYCIAVJzyzMfaazGmIgtBNI Wqswk4TANFw+nVpjl4h/ySBmU4F1ACOhqEEE0pQiWUuaK6tioJs71UGz91pkS3lXmrQcxVxKg7Fgq 19ilcGj2nugseoH58Vqk+5kec; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:55588 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pfk5u-00357N-IG; Fri, 24 Mar 2023 10:16:46 -0600 From: Tom Tromey To: Hui Li Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/elfread.c: Add plt symbol check for _PROCEDURE_LINKAGE_TABLE_ References: <20230323075908.23013-1-lihui@loongson.cn> X-Attribution: Tom Date: Fri, 24 Mar 2023 10:16:44 -0600 In-Reply-To: <20230323075908.23013-1-lihui@loongson.cn> (Hui Li's message of "Thu, 23 Mar 2023 15:59:08 +0800") Message-ID: <87pm8ydt03.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1pfk5u-00357N-IG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (murgatroyd) [71.211.185.113]:55588 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3017.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Hui Li writes: > This is because some architectures such as LoongArch define the symbol > _PROCEDURE_LINKAGE_TABLE_ at the start of the .plt section. Add plt > symbol check for _PROCEDURE_LINKAGE_TABLE_ to improved the judgment of > plt symbol and to get correct target function address of STT_GNU_IFUNC. It would be helpful to know how precisely things go wrong. The patch itself seems reasonable enough -- hacky maybe but not out of the ordinary way -- but I don't understand how it relates to the problem. Like, why does ignoring this symbol here affect the results? Tom